Move CreateCommitBuffer into Commit

There is no particular need for the repository, so make this a static
method in Commit and pass in the repo from the tree to the library.

Author: carlosmn

LibGit2Sharp.Tests/CommitFixture.cs

@@ -1130,7 +1130,7 @@ public void CanCreateACommitString()
             using (var repo = new Repository(repoPath))
             {
                 var tipCommit = repo.Head.Tip;
-                var recreatedCommit = repo.ObjectDatabase.CreateCommitBuffer(
+                var recreatedCommit = Commit.CreateBuffer(
                     tipCommit.Author,
                     tipCommit.Committer,
                     tipCommit.Message,

LibGit2Sharp/Commit.cs

@@ -150,6 +150,44 @@ public static SignatureInfo ExtractSignature(Repository repo, ObjectId id)
             return Proxy.git_commit_extract_signature(repo.Handle, id, null);
         }
 
+        /// <summary>
+        /// Create a commit in-memroy
+        /// <para>
+        /// Prettifing the message includes:
+        /// * Removing empty lines from the beginning and end.
+        /// * Removing trailing spaces from every line.
+        /// * Turning multiple consecutive empty lines between paragraphs into just one empty line.
+        /// * Ensuring the commit message ends with a newline.
+        /// * Removing every line starting with the <paramref name="commentChar"/>.
+        /// </para>
+        /// </summary>
+        /// <param name="author">The <see cref="Signature"/> of who made the change.</param>
+        /// <param name="committer">The <see cref="Signature"/> of who added the change to the repository.</param>
+        /// <param name="message">The description of why a change was made to the repository.</param>
+        /// <param name="tree">The <see cref="Tree"/> of the <see cref="Commit"/> to be created.</param>
+        /// <param name="parents">The parents of the <see cref="Commit"/> to be created.</param>
+        /// <param name="prettifyMessage">True to prettify the message, or false to leave it as is.</param>
+        /// <param name="commentChar">When non null, lines starting with this character will be stripped if prettifyMessage is true.</param>
+        /// <returns>The contents of the commit object.</returns>
+        public static string CreateBuffer(Signature author, Signature committer, string message, Tree tree, IEnumerable<Commit> parents, bool prettifyMessage, char? commentChar)
+        {
+            Ensure.ArgumentNotNull(message, "message");
+            Ensure.ArgumentDoesNotContainZeroByte(message, "message");
+            Ensure.ArgumentNotNull(author, "author");
+            Ensure.ArgumentNotNull(committer, "committer");
+            Ensure.ArgumentNotNull(tree, "tree");
+            Ensure.ArgumentNotNull(parents, "parents");
+
+            if (prettifyMessage)
+            {
+                message = Proxy.git_message_prettify(message, commentChar);
+            }
+            var treeHandle = Proxy.git_object_lookup(tree.repo.Handle, tree.Id, GitObjectType.Tree);
+            var handles = parents.Select(c => Proxy.git_object_lookup(c.repo.Handle, c.Id, GitObjectType.Commit));
+
+            return Proxy.git_commit_create_buffer(tree.repo.Handle, author, committer, message, treeHandle, handles.ToArray());
+        }
+
         private class ParentsCollection : ICollection<Commit>
         {
             private readonly Lazy<ICollection<Commit>> _parents;

LibGit2Sharp/GitObject.cs

@@ -28,7 +28,7 @@ public abstract class GitObject : IEquatable<GitObject>, IBelongToARepository
         /// <summary>
         /// The <see cref="Repository"/> containing the object.
         /// </summary>
-        protected readonly Repository repo;
+        internal readonly Repository repo;
 
         /// <summary>
         /// Needed for mocking purposes.

LibGit2Sharp/ObjectDatabase.cs

@@ -422,44 +422,6 @@ public virtual Commit CreateCommit(Signature author, Signature committer, string
             return commit;
         }
 
-        /// <summary>
-        /// Create a commit in-memory but do not write it to the object database.
-        /// <para>
-        /// Prettifing the message includes:
-        /// * Removing empty lines from the beginning and end.
-        /// * Removing trailing spaces from every line.
-        /// * Turning multiple consecutive empty lines between paragraphs into just one empty line.
-        /// * Ensuring the commit message ends with a newline.
-        /// * Removing every line starting with the <paramref name="commentChar"/>.
-        /// </para>
-        /// </summary>
-        /// <param name="author">The <see cref="Signature"/> of who made the change.</param>
-        /// <param name="committer">The <see cref="Signature"/> of who added the change to the repository.</param>
-        /// <param name="message">The description of why a change was made to the repository.</param>
-        /// <param name="tree">The <see cref="Tree"/> of the <see cref="Commit"/> to be created.</param>
-        /// <param name="parents">The parents of the <see cref="Commit"/> to be created.</param>
-        /// <param name="prettifyMessage">True to prettify the message, or false to leave it as is.</param>
-        /// <param name="commentChar">When non null, lines starting with this character will be stripped if prettifyMessage is true.</param>
-        /// <returns>The contents of the commit object.</returns>
-        public virtual string CreateCommitBuffer(Signature author, Signature committer, string message, Tree tree, IEnumerable<Commit> parents, bool prettifyMessage, char? commentChar)
-        {
-            Ensure.ArgumentNotNull(message, "message");
-            Ensure.ArgumentDoesNotContainZeroByte(message, "message");
-            Ensure.ArgumentNotNull(author, "author");
-            Ensure.ArgumentNotNull(committer, "committer");
-            Ensure.ArgumentNotNull(tree, "tree");
-            Ensure.ArgumentNotNull(parents, "parents");
-
-            if (prettifyMessage)
-            {
-                message = Proxy.git_message_prettify(message, commentChar);
-            }
-            var treeHandle = Proxy.git_object_lookup(repo.Handle, tree.Id, GitObjectType.Tree);
-            var handles = parents.Select(c => Proxy.git_object_lookup(repo.Handle, c.Id, GitObjectType.Commit));
-
-            return Proxy.git_commit_create_buffer(repo.Handle, author, committer, message, treeHandle, handles.ToArray());
-        }
-
         /// <summary>
         /// Inserts a <see cref="Commit"/> into the object database after attaching the given signature.
         /// </summary>