Skip to content

Commit 3a9a77f

Browse files
shiftkeynulltoken
authored andcommitted
Drop optional parameters in TagCollectionExtensions.cs
1 parent 51c2ddc commit 3a9a77f

File tree

1 file changed

+26
-2
lines changed

1 file changed

+26
-2
lines changed

LibGit2Sharp/TagCollectionExtensions.cs

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,19 @@ namespace LibGit2Sharp
77
/// </summary>
88
public static class TagCollectionExtensions
99
{
10+
/// <summary>
11+
/// Creates an annotated tag with the specified name.
12+
/// </summary>
13+
/// <param name="name">The name.</param>
14+
/// <param name="objectish">Revparse spec for the target object.</param>
15+
/// <param name="tagger">The tagger.</param>
16+
/// <param name="message">The message.</param>
17+
/// <param name="tags">The <see cref="TagCollection"/> being worked with.</param>
18+
public static Tag Add(this TagCollection tags, string name, string objectish, Signature tagger, string message)
19+
{
20+
return tags.Add(name, objectish, tagger, message, false);
21+
}
22+
1023
/// <summary>
1124
/// Creates an annotated tag with the specified name.
1225
/// </summary>
@@ -16,7 +29,7 @@ public static class TagCollectionExtensions
1629
/// <param name="message">The message.</param>
1730
/// <param name="allowOverwrite">True to allow silent overwriting a potentially existing tag, false otherwise.</param>
1831
/// <param name="tags">The <see cref="TagCollection"/> being worked with.</param>
19-
public static Tag Add(this TagCollection tags, string name, string objectish, Signature tagger, string message, bool allowOverwrite = false)
32+
public static Tag Add(this TagCollection tags, string name, string objectish, Signature tagger, string message, bool allowOverwrite)
2033
{
2134
Ensure.ArgumentNotNullOrEmptyString(objectish, "target");
2235

@@ -25,14 +38,25 @@ public static Tag Add(this TagCollection tags, string name, string objectish, Si
2538
return tags.Add(name, objectToTag, tagger, message, allowOverwrite);
2639
}
2740

41+
/// <summary>
42+
/// Creates a lightweight tag with the specified name.
43+
/// </summary>
44+
/// <param name="name">The name.</param>
45+
/// <param name="objectish">Revparse spec for the target object.</param>
46+
/// <param name="tags">The <see cref="TagCollection"/> being worked with.</param>
47+
public static Tag Add(this TagCollection tags, string name, string objectish)
48+
{
49+
return tags.Add(name, objectish, false);
50+
}
51+
2852
/// <summary>
2953
/// Creates a lightweight tag with the specified name.
3054
/// </summary>
3155
/// <param name="name">The name.</param>
3256
/// <param name="objectish">Revparse spec for the target object.</param>
3357
/// <param name="allowOverwrite">True to allow silent overwriting a potentially existing tag, false otherwise.</param>
3458
/// <param name="tags">The <see cref="TagCollection"/> being worked with.</param>
35-
public static Tag Add(this TagCollection tags, string name, string objectish, bool allowOverwrite = false)
59+
public static Tag Add(this TagCollection tags, string name, string objectish, bool allowOverwrite)
3660
{
3761
Ensure.ArgumentNotNullOrEmptyString(objectish, "objectish");
3862

0 commit comments

Comments
 (0)