Use DirectReference as Repository ListRemoteReferences Return Type

Author: psawey

LibGit2Sharp.Tests/RepositoryFixture.cs

@@ -659,7 +659,7 @@ public void CanListRemoteReferencesWithCredentials()
             InconclusiveIf(() => string.IsNullOrEmpty(Constants.PrivateRepoUrl),
                 "Populate Constants.PrivateRepo* to run this test");
 
-            IEnumerable<Reference> references = Repository.ListRemoteReferences(Constants.PrivateRepoUrl,
+            IEnumerable<DirectReference> references = Repository.ListRemoteReferences(Constants.PrivateRepoUrl,
                 Constants.PrivateRepoCredentials);
 
             foreach (var reference in references)
@@ -674,7 +674,7 @@ public void CanListRemoteReferencesWithCredentials()
         [InlineData("git://github.com/libgit2/TestGitRepository.git")]
         public void CanListRemoteReferences(string url)
         {
-            IEnumerable<Reference> references = Repository.ListRemoteReferences(url);
+            IEnumerable<DirectReference> references = Repository.ListRemoteReferences(url);
 
             List<Tuple<string, string>> actualRefs = references.
                 Select(directRef => new Tuple<string, string>(directRef.CanonicalName, directRef.TargetIdentifier)).ToList();
@@ -691,7 +691,7 @@ public void CanListRemoteReferences(string url)
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         public void ReadingReferenceRepositoryThroughListRemoteReferencesThrows(string url)
         {
-            IEnumerable<Reference> references = Repository.ListRemoteReferences(url);
+            IEnumerable<DirectReference> references = Repository.ListRemoteReferences(url);
 
             foreach (var reference in references)
             {
@@ -704,12 +704,11 @@ public void ReadingReferenceRepositoryThroughListRemoteReferencesThrows(string u
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         public void ReadingReferenceTargetFromListRemoteReferencesThrows(string url)
         {
-            IEnumerable<Reference> references = Repository.ListRemoteReferences(url);
+            IEnumerable<DirectReference> references = Repository.ListRemoteReferences(url);
 
             foreach (var reference in references)
             {
-                var directReference = (DirectReference)reference;
-                Assert.Throws<InvalidOperationException>(() => directReference.Target);
+                Assert.Throws<InvalidOperationException>(() => reference.Target);
             }
         }
     }

LibGit2Sharp/Core/Proxy.cs

@@ -2172,11 +2172,6 @@ public static RepositorySafeHandle git_repository_new()
             RepositorySafeHandle repo;
             int res = NativeMethods.git_repository_new(out repo);
 
-            if (res == (int)GitErrorCode.Error)
-            {
-                throw new LibGit2SharpException("Unable to create new Repository");
-            }
-
             Ensure.ZeroResult(res);
 
             return repo;

LibGit2Sharp/DirectReference.cs

@@ -21,7 +21,9 @@ internal DirectReference(string canonicalName, IRepository repo, ObjectId target
             targetBuilder = new Lazy<GitObject>(() =>
             {
                 if (repo == null)
+                {
                     throw new InvalidOperationException("Target requires a local repository");
+                }
 
                 return repo.Lookup(targetId);
             });

LibGit2Sharp/Reference.cs

@@ -204,7 +204,9 @@ IRepository IBelongToARepository.Repository
             get
             {
                 if (repo == null)
+                {
                     throw new InvalidOperationException("Repository requires a local repository");
+                }
 
                 return repo;
             }

LibGit2Sharp/Repository.cs

@@ -555,7 +555,7 @@ internal Commit LookupCommit(string committish)
         /// </para>
         /// <param name="url">The url to list from.</param>
         /// <returns>The references in the remote repository.</returns>
-        public static IEnumerable<Reference> ListRemoteReferences(string url)
+        public static IEnumerable<DirectReference> ListRemoteReferences(string url)
         {
             return ListRemoteReferences(url, null);
         }
@@ -571,7 +571,7 @@ public static IEnumerable<Reference> ListRemoteReferences(string url)
         /// <param name="url">The url to list from.</param>
         /// <param name="credentialsProvider">The <see cref="Func{Credentials}"/> used to connect to remote repository.</param>
         /// <returns>The references in the remote repository.</returns>
-        public static IEnumerable<Reference> ListRemoteReferences(string url, CredentialsHandler credentialsProvider)
+        public static IEnumerable<DirectReference> ListRemoteReferences(string url, CredentialsHandler credentialsProvider)
         {
             Ensure.ArgumentNotNull(url, "url");