Index.Unstage should accept absolute file paths

Author: nulltoken

LibGit2Sharp.Tests/IndexFixture.cs

@@ -341,7 +341,7 @@ public void CanUnstageTheRemovalOfAFile()
         }
 
         [Fact]
-        public void CanUnstageUntrackedFileInAnEmptyRepository()
+        public void CanUnstageUntrackedFileAgainstAnOrphanedHead()
         {
             SelfCleaningDirectory scd = BuildSelfCleaningDirectory();
 
@@ -360,6 +360,41 @@ public void CanUnstageUntrackedFileInAnEmptyRepository()
             }
         }
 
+        [Fact]
+        public void UnstagingANewFileWithAFullPathWhichEscapesOutOfTheWorkingDirThrows()
+        {
+            SelfCleaningDirectory scd = BuildSelfCleaningDirectory();
+            TemporaryCloneOfTestRepo path = BuildTemporaryCloneOfTestRepo(StandardTestRepoWorkingDirPath);
+            using (var repo = new Repository(path.RepositoryPath))
+            {
+                DirectoryInfo di = Directory.CreateDirectory(scd.DirectoryPath);
+
+                const string filename = "unit_test.txt";
+                string fullPath = Path.Combine(di.FullName, filename);
+                File.WriteAllText(fullPath, "some contents");
+
+                Assert.Throws<ArgumentException>(() => repo.Index.Unstage(fullPath));
+            }
+        }
+
+        [Fact]
+        public void UnstagingANewFileWithAFullPathWhichEscapesOutOfTheWorkingDirAgainstAnOrphanedHeadThrows()
+        {
+            SelfCleaningDirectory scd = BuildSelfCleaningDirectory();
+            SelfCleaningDirectory scd2 = BuildSelfCleaningDirectory();
+
+            using (var repo = Repository.Init(scd2.DirectoryPath))
+            {
+                DirectoryInfo di = Directory.CreateDirectory(scd.DirectoryPath);
+
+                const string filename = "unit_test.txt";
+                string fullPath = Path.Combine(di.FullName, filename);
+                File.WriteAllText(fullPath, "some contents");
+
+                Assert.Throws<ArgumentException>(() => repo.Index.Unstage(fullPath));
+            }
+        }
+
         [Fact]
         public void UnstagingFileWithBadParamsThrows()
         {

LibGit2Sharp/Index.cs

@@ -211,7 +211,19 @@ public virtual void Unstage(string path)
         /// <param name = "paths">The collection of paths of the files within the working directory.</param>
         public virtual void Unstage(IEnumerable<string> paths)
         {
-            Commit commit = repo.Lookup("HEAD",
+            Ensure.ArgumentNotNull(paths, "paths");
+
+            IEnumerable<KeyValuePair<string, FileStatus>> batch = PrepareBatch(paths);
+
+            foreach (KeyValuePair<string, FileStatus> kvp in batch)
+            {
+                if (Directory.Exists(kvp.Key))
+                {
+                    throw new NotImplementedException();
+                }
+            }
+
+            var commit = repo.Lookup("HEAD",
                                         GitObjectType.Any,
                                         LookUpOptions.DereferenceResultToCommit) as Commit;