fix: noreplace.

Author: ldez

pkg/golinters/noreplace.go

@@ -4,50 +4,53 @@ import (
 	"sync"
 
 	"git.sr.ht/~urandom/noreplace"
-	"golang.org/x/tools/go/analysis"
-
 	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
 	"github.com/golangci/golangci-lint/pkg/result"
+	"golang.org/x/tools/go/analysis"
 )
 
-const noreplaceName = "noreplace"
+const noReplaceName = "noreplace"
 
-// NewNoreplace returns a new noreplace linter.
-func NewNoreplace() *goanalysis.Linter {
+// NewNoReplace returns a new noreplace linter.
+func NewNoReplace() *goanalysis.Linter {
 	var issues []goanalysis.Issue
-	var mu sync.Mutex
+	var once sync.Once
+
 	analyzer := &analysis.Analyzer{
 		Name: goanalysis.TheOnlyAnalyzerName,
 		Doc:  goanalysis.TheOnlyanalyzerDoc,
 	}
+
 	return goanalysis.NewLinter(
-		noreplaceName,
+		noReplaceName,
 		"Block the use of replace directives Go modules.",
 		[]*analysis.Analyzer{analyzer},
 		nil,
 	).WithContextSetter(func(lintCtx *linter.Context) {
 		analyzer.Run = func(pass *analysis.Pass) (interface{}, error) {
-			pp, err := noreplace.Check()
-			if err != nil {
-				lintCtx.Log.Warnf("running %s failed: %s: if you are not using go modules "+
-					"it is suggested to disable this linter", noreplaceName, err)
-				return nil, nil
-			}
-			mu.Lock()
-			defer mu.Unlock()
-			for _, p := range pp {
-				issues = append(issues, goanalysis.NewIssue(&result.Issue{
-					FromLinter:  noreplaceName,
-					Pos:         p[0],
-					LineRange:   &result.Range{From: p[0].Line, To: p[1].Line},
-					Replacement: &result.Replacement{NeedOnlyDelete: true},
-					Text:        noreplace.Text,
-				}, pass))
-			}
+			once.Do(func() {
+				pp, err := noreplace.Check()
+				if err != nil {
+					lintCtx.Log.Warnf("running %s failed: %s: if you are not using go modules "+
+						"it is suggested to disable this linter", noReplaceName, err)
+					return
+				}
+
+				for _, p := range pp {
+					issues = append(issues, goanalysis.NewIssue(&result.Issue{
+						FromLinter:  noReplaceName,
+						Pos:         p[0],
+						LineRange:   &result.Range{From: p[0].Line, To: p[1].Line},
+						Replacement: &result.Replacement{NeedOnlyDelete: true},
+						Text:        noreplace.Text,
+					}, pass))
+				}
+			})
+
 			return nil, nil
 		}
 	}).WithIssuesReporter(func(*linter.Context) []goanalysis.Issue {
 		return issues
-	})
+	}).WithLoadMode(goanalysis.LoadModeSyntax)
 }

pkg/lint/lintersdb/manager.go

@@ -394,7 +394,9 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle).
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/gostaticanalysis/forcetypeassert"),
-		linter.NewConfig(golinters.NewNoreplace()).
+		linter.NewConfig(golinters.NewNoReplace()).
+			WithPresets(linter.PresetStyle).
+			WithLoadForGoAnalysis().
 			WithAutoFix().
 			WithURL("https://git.sr.ht/~urandom/noreplace"),