Skip to content

Commit 10436a5

Browse files
committed
fixed calling ArrayEditorWidget with invalid arguments
xlabels and ylabels arguments no longer exist for ArrayEditorWidget also removed the arguments from ArrayEditor.setup_and_check since they are no longer used reordered remaining argument in the order of the called function to spot these error a bit more easily
1 parent e0df34b commit 10436a5

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

larray_editor/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def edit(obj=None, title='', minvalue=None, maxvalue=None, readonly=False, depth
130130
from larray_editor.editor import ArrayEditor
131131
dlg = ArrayEditor(parent)
132132

133-
if dlg.setup_and_check(obj, title=title, minvalue=minvalue, maxvalue=maxvalue, readonly=readonly):
133+
if dlg.setup_and_check(obj, title=title, readonly=readonly, minvalue=minvalue, maxvalue=maxvalue):
134134
if parent or isinstance(dlg, QMainWindow):
135135
dlg.show()
136136
_app.exec_()

larray_editor/arraywidget.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,8 @@ def __init__(self, parent, data_scrollbar):
506506

507507

508508
class ArrayEditorWidget(QWidget):
509-
def __init__(self, parent, data=None, readonly=False, bg_value=None, bg_gradient=None, minvalue=None, maxvalue=None):
509+
def __init__(self, parent, data=None, readonly=False, bg_value=None, bg_gradient=None,
510+
minvalue=None, maxvalue=None):
510511
QWidget.__init__(self, parent)
511512
readonly = np.isscalar(data)
512513
self.readonly = readonly

larray_editor/editor.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -725,9 +725,7 @@ def __init__(self, parent=None):
725725
self.data = None
726726
self.arraywidget = None
727727

728-
def setup_and_check(self, data, title='', readonly=False,
729-
xlabels=None, ylabels=None,
730-
minvalue=None, maxvalue=None):
728+
def setup_and_check(self, data, title='', readonly=False, minvalue=None, maxvalue=None):
731729
"""
732730
Setup ArrayEditor:
733731
return False if data is not supported, True otherwise
@@ -756,8 +754,7 @@ def setup_and_check(self, data, title='', readonly=False,
756754
self.resize(800, 600)
757755
self.setMinimumSize(400, 300)
758756

759-
self.arraywidget = ArrayEditorWidget(self, data, readonly, xlabels, ylabels,
760-
minvalue=minvalue, maxvalue=maxvalue)
757+
self.arraywidget = ArrayEditorWidget(self, data, readonly, minvalue=minvalue, maxvalue=maxvalue)
761758
layout.addWidget(self.arraywidget, 1, 0)
762759

763760
# Buttons configuration

0 commit comments

Comments
 (0)