feat: (LAR-77) Correction des messages composer phpstan

Author: Stephen2304

app/Http/Controllers/Auth/VerifyEmailController.php

@@ -1,25 +1,33 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Http\Controllers\Auth;
 
 use App\Http\Controllers\Controller;
 use Illuminate\Auth\Events\Verified;
 use Illuminate\Foundation\Auth\EmailVerificationRequest;
 use Illuminate\Http\RedirectResponse;
 
-class VerifyEmailController extends Controller
+final class VerifyEmailController extends Controller
 {
     /**
      * Mark the authenticated user's email address as verified.
      */
     public function __invoke(EmailVerificationRequest $request): RedirectResponse
     {
-        if ($request->user()->hasVerifiedEmail()) {
+        $user = $request->user();
+
+        if ($user === null) {
+            return redirect()->route('login');
+        }
+
+        if ($user->hasVerifiedEmail()) {
             return redirect()->intended(route('dashboard', absolute: false).'?verified=1');
         }
 
-        if ($request->user()->markEmailAsVerified()) {
-            event(new Verified($request->user()));
+        if ($user->markEmailAsVerified()) {
+            event(new Verified($user));
         }
 
         return redirect()->intended(route('dashboard', absolute: false).'?verified=1');

app/Livewire/Forms/LoginForm.php

@@ -16,8 +16,9 @@ class LoginForm extends Form
     public string $password = '';
     public bool $remember = false;
 
-    public function __construct(Component $component = null, $name = 'form')
+    public function __construct(Component $component = null, string $name = 'form')
     {
+        $component = $component ?? app(Component::class);
         parent::__construct($component, $name);
     }
 
@@ -30,7 +31,7 @@ public function authenticate(): void
     {
         $this->ensureIsNotRateLimited();
 
-        if (! Auth::attempt(['email' => $this->email, 'password' => $this->password], $this->remember)) {
+        if (!Auth::attempt(['email' => $this->email, 'password' => $this->password], $this->remember)) {
             RateLimiter::hit($this->throttleKey());
 
             throw ValidationException::withMessages([
@@ -46,7 +47,7 @@ public function authenticate(): void
      */
     protected function ensureIsNotRateLimited(): void
     {
-        if (! RateLimiter::tooManyAttempts($this->throttleKey(), 5)) {
+        if (!RateLimiter::tooManyAttempts($this->throttleKey(), 5)) {
             return;
         }
 
@@ -67,6 +68,6 @@ protected function ensureIsNotRateLimited(): void
      */
     protected function throttleKey(): string
     {
-        return Str::transliterate(Str::lower($this->email).'|'.request()->ip());
+        return Str::transliterate(Str::lower($this->email) . '|' . request()->ip());
     }
 }

app/Livewire/Pages/Auth/Login.php

@@ -1,18 +1,21 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Livewire\Pages\Auth;
 
+use Illuminate\View\View;
 use App\Livewire\Forms\LoginForm;
 use Illuminate\Support\Facades\Session;
-use Livewire\Component;
 use Livewire\Attributes\Layout;
+use Livewire\Component;
 
 // #[Layout('layouts.guest')]
-class Login extends Component
+final class Login extends Component
 {
     public LoginForm $form;
 
-    public function boot()
+    public function boot(): void
     {
         $this->form = new LoginForm($this);
     }
@@ -32,8 +35,8 @@ public function login(): void
         $this->redirectIntended(route('dashboard'));
     }
 
-    public function render()
+    public function render(): View
     {
         return view('livewire.pages.auth.login');
     }
-}
+}

app/Providers/VoltServiceProvider.php

@@ -1,11 +1,13 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Providers;
 
 use Illuminate\Support\ServiceProvider;
 use Livewire\Volt\Volt;
 
-class VoltServiceProvider extends ServiceProvider
+final class VoltServiceProvider extends ServiceProvider
 {
     /**
      * Register services.

routes/auth.php

@@ -1,10 +1,12 @@
 <?php
 
+declare(strict_types=1);
+
 use App\Http\Controllers\Auth\VerifyEmailController;
 use Illuminate\Support\Facades\Route;
 use Livewire\Volt\Volt;
 
-Route::middleware('guest')->group(function () {
+Route::middleware('guest')->group(function (): void {
     Volt::route('register', 'pages.auth.register')
         ->name('register');
 
@@ -18,7 +20,7 @@
         ->name('password.reset');
 });
 
-Route::middleware('auth')->group(function () {
+Route::middleware('auth')->group(function (): void {
     Volt::route('verify-email', 'pages.auth.verify-email')
         ->name('verification.notice');
 

routes/web.php

@@ -86,5 +86,4 @@
 Route::get('sponsors', [SponsoringController::class, 'sponsors'])->name('sponsors');
 Route::get('callback-payment', NotchPayCallBackController::class)->name('notchpay-callback');
 
-
-require __DIR__.'/auth.php';
+require __DIR__.'/auth.php';

tests/Feature/Auth/AuthenticationTest.php

@@ -1,17 +1,19 @@
 <?php
 
+declare(strict_types=1);
+
 use App\Models\User;
 use Livewire\Volt\Volt;
 
-test('login screen can be rendered', function () {
+test('login screen can be rendered', function (): void {
     $response = $this->get('/login');
 
     $response
         ->assertOk()
         ->assertSeeVolt('pages.auth.login');
 });
 
-test('users can authenticate using the login screen', function () {
+test('users can authenticate using the login screen', function (): void {
     $user = User::factory()->create();
 
     $component = Volt::test('pages.auth.login')
@@ -27,7 +29,7 @@
     $this->assertAuthenticated();
 });
 
-test('users can not authenticate with invalid password', function () {
+test('users can not authenticate with invalid password', function (): void {
     $user = User::factory()->create();
 
     $component = Volt::test('pages.auth.login')
@@ -43,7 +45,7 @@
     $this->assertGuest();
 });
 
-test('navigation menu can be rendered', function () {
+test('navigation menu can be rendered', function (): void {
     $user = User::factory()->create();
 
     $this->actingAs($user);
@@ -55,7 +57,7 @@
         ->assertSeeVolt('layout.navigation');
 });
 
-test('users can logout', function () {
+test('users can logout', function (): void {
     $user = User::factory()->create();
 
     $this->actingAs($user);

tests/Feature/Auth/EmailVerificationTest.php

@@ -1,19 +1,21 @@
 <?php
 
+declare(strict_types=1);
+
 use App\Models\User;
 use Illuminate\Auth\Events\Verified;
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\URL;
 
-test('email verification screen can be rendered', function () {
+test('email verification screen can be rendered', function (): void {
     $user = User::factory()->unverified()->create();
 
     $response = $this->actingAs($user)->get('/verify-email');
 
     $response->assertStatus(200);
 });
 
-test('email can be verified', function () {
+test('email can be verified', function (): void {
     $user = User::factory()->unverified()->create();
 
     Event::fake();
@@ -31,7 +33,7 @@
     $response->assertRedirect(route('dashboard', absolute: false).'?verified=1');
 });
 
-test('email is not verified with invalid hash', function () {
+test('email is not verified with invalid hash', function (): void {
     $user = User::factory()->unverified()->create();
 
     $verificationUrl = URL::temporarySignedRoute(

tests/Feature/Auth/PasswordConfirmationTest.php

@@ -1,11 +1,13 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Tests\Feature\Auth;
 
 use App\Models\User;
 use Livewire\Volt\Volt;
 
-test('confirm password screen can be rendered', function () {
+test('confirm password screen can be rendered', function (): void {
     $user = User::factory()->create();
 
     $response = $this->actingAs($user)->get('/confirm-password');
@@ -15,7 +17,7 @@
         ->assertStatus(200);
 });
 
-test('password can be confirmed', function () {
+test('password can be confirmed', function (): void {
     $user = User::factory()->create();
 
     $this->actingAs($user);
@@ -30,7 +32,7 @@
         ->assertHasNoErrors();
 });
 
-test('password is not confirmed with invalid password', function () {
+test('password is not confirmed with invalid password', function (): void {
     $user = User::factory()->create();
 
     $this->actingAs($user);

tests/Feature/Auth/PasswordResetTest.php

@@ -1,21 +1,23 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Tests\Feature\Auth;
 
 use App\Models\User;
 use Illuminate\Auth\Notifications\ResetPassword;
 use Illuminate\Support\Facades\Notification;
 use Livewire\Volt\Volt;
 
-test('reset password link screen can be rendered', function () {
+test('reset password link screen can be rendered', function (): void {
     $response = $this->get('/forgot-password');
 
     $response
         ->assertSeeVolt('pages.auth.forgot-password')
         ->assertStatus(200);
 });
 
-test('reset password link can be requested', function () {
+test('reset password link can be requested', function (): void {
     Notification::fake();
 
     $user = User::factory()->create();
@@ -27,7 +29,7 @@
     Notification::assertSentTo($user, ResetPassword::class);
 });
 
-test('reset password screen can be rendered', function () {
+test('reset password screen can be rendered', function (): void {
     Notification::fake();
 
     $user = User::factory()->create();
@@ -47,7 +49,7 @@
     });
 });
 
-test('password can be reset with valid token', function () {
+test('password can be reset with valid token', function (): void {
     Notification::fake();
 
     $user = User::factory()->create();

tests/Feature/Auth/PasswordUpdateTest.php

@@ -1,12 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Tests\Feature\Auth;
 
 use App\Models\User;
 use Illuminate\Support\Facades\Hash;
 use Livewire\Volt\Volt;
 
-test('password can be updated', function () {
+test('password can be updated', function (): void {
     $user = User::factory()->create();
 
     $this->actingAs($user);
@@ -24,7 +26,7 @@
     $this->assertTrue(Hash::check('new-password', $user->refresh()->password));
 });
 
-test('correct password must be provided to update password', function () {
+test('correct password must be provided to update password', function (): void {
     $user = User::factory()->create();
 
     $this->actingAs($user);

tests/Feature/Auth/RegistrationTest.php

@@ -1,18 +1,20 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Tests\Feature\Auth;
 
 use Livewire\Volt\Volt;
 
-test('registration screen can be rendered', function () {
+test('registration screen can be rendered', function (): void {
     $response = $this->get('/register');
 
     $response
         ->assertOk()
         ->assertSeeVolt('pages.auth.register');
 });
 
-test('new users can register', function () {
+test('new users can register', function (): void {
     $component = Volt::test('pages.auth.register')
         ->set('name', 'Test User')
         ->set('email', 'test@example.com')