fix(LAR-66): Laravel notification pending articles (#157)

Co-authored-by: mckenziearts <mckenziearts@users.noreply.github.com>

Author: mckenziearts

.github/FUNDING.yml

@@ -1,2 +1,3 @@
 custom: https://laravel.cm/sponsors
+github: mckenziearts
 

.github/actions/setup/action.yml

@@ -0,0 +1,28 @@
+name: CI Setup
+description: "Sets up the environment for jobs during CI workflow"
+
+runs:
+  using: composite
+  steps:
+    - name: 🐘 Setup PHP
+      uses: shivammathur/setup-php@v2
+      with:
+        php-version: "8.2"
+        extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, pdo_mysql, bcmath, soap, intl, gd, exif, iconv, imagick
+        tools: composer:v2
+        coverage: none
+    - name: ℹ Setup Problem Matches
+      shell: sh
+      run: |
+        echo "::add-matcher::${{ runner.tool_cache }}/php.json"
+        echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
+    - name: 🗂 Get composer cache directory
+      id: composer-cache
+      shell: sh
+      run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+    - name: Cache dependencies
+      uses: actions/cache@v3
+      with:
+        path: ${{ steps.composer-cache.outputs.dir }}
+        key: ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}
+        restore-keys: ${{ runner.os }}-composer-

.github/workflows/coding-standards.yml

@@ -0,0 +1,49 @@
+name: Quality
+
+on:
+  push:
+    branches:
+      - main
+      - develop
+  pull_request:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  pint:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: 👀 Checkout
+        uses: actions/checkout@v3
+      - name: 🪄 Setup
+        uses: ./.github/actions/setup
+      - name: 🔮 Install Composer Dependencies
+        run: composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
+      - name: 🕵️‍♂️ Run Laravel Pint
+        run: composer lint -- --test
+
+  phpstan:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: 👀 Checkout
+        uses: actions/checkout@v3
+      - name: 🪄 Setup
+        uses: ./.github/actions/setup
+      - name: 🔮 Install Composer Dependencies
+        run: composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
+      - name: 🕵️‍♂️ Run PHPStan
+        run: composer test:phpstan -- --ansi --no-interaction --no-progress --error-format=github
+
+  composer:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: 👀 Checkout
+        uses: actions/checkout@v3
+      - name: 🪄 Setup
+        uses: ./.github/actions/setup
+      - name: 🕵️‍♂️ Run Composer Validate
+        run: composer validate
+      - name: 🕵️‍♂️ Run Composer Audit
+        run: composer audit

.github/workflows/phpstan.yml

@@ -1,25 +1,30 @@
 name: Tests
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - main
+      - develop
+  pull_request:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
-  tests:
-    runs-on: ubuntu-latest
+  pest:
+    runs-on: ubuntu-22.04
 
     steps:
-      - name: Checkout code
+      - name: 👀 Checkout
         uses: actions/checkout@v4
-
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: 8.2
-          extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite
-          tools: composer:v2
-          coverage: none
-
-      - name: Install Composer dependencies
-        run: composer install --prefer-dist --no-interaction
-
-      - name: Execute tests
-        run: composer pest
+      - name: 🪄 Setup
+        uses: ./.github/actions/setup
+      - name: 🔮 Install Composer Dependencies
+        run: composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
+      - name: 🧶 Install Node Dependencies
+        run: yarn install --frozen-lockfile --no-progress
+      - name: 🧱 Build JS Dependencies
+        run: yarn build
+      - name: 🕵️‍♂️ Run Pest Tests
+        run: composer test:pest

.github/workflows/quality.yml

@@ -15,6 +15,7 @@ composer.phar
 
 # Laravel Exclude
 #
+.phpunit.cache
 .phpunit.result.cache
 /public/build
 /public/**/filament

.github/workflows/tests.yml

@@ -19,7 +19,7 @@ public function update(User $user, array $input): void
             'current_password' => ['required', 'string'],
             'password' => $this->passwordRules(),
         ])->after(function ($validator) use ($user, $input): void {
-            if ( ! isset($input['current_password']) || ! Hash::check($input['current_password'], $user->password)) {
+            if (! isset($input['current_password']) || ! Hash::check($input['current_password'], $user->password)) {
                 $validator->errors()->add('current_password', __('Le mot de passe fourni ne correspond pas à votre mot de passe actuel.'));
             }
         })->validateWithBag('updatePassword');

.gitignore

@@ -26,7 +26,7 @@ public function handle(): void
 
         if ($users->isNotEmpty()) {
             foreach ($users as $user) {
-                $user->notify((new SendEMailToDeletedUser())->delay(now()->addMinutes(5)));
+                $user->notify((new SendEMailToDeletedUser)->delay(now()->addMinutes(5)));
             }
         }
 

Makefile

@@ -5,10 +5,10 @@
 namespace App\Console\Commands;
 
 use App\Models\User;
+use Exception;
 use Illuminate\Console\Command;
 use Illuminate\Database\QueryException;
 use Illuminate\Support\Facades\Hash;
-use Exception;
 
 final class CreateAdminUser extends Command
 {

app/Actions/Fortify/UpdateUserPassword.php

@@ -5,9 +5,9 @@
 namespace App\Console\Commands;
 
 use App\Models\Article;
+use App\Notifications\PendingArticlesNotification;
 use Illuminate\Console\Command;
 use Illuminate\Notifications\AnonymousNotifiable;
-use App\Notifications\PendingArticlesNotification;
 
 final class NotifyPendingArticles extends Command
 {

app/Console/Commands/Cleanup/DeleteOldUnverifiedUsers.php

@@ -23,7 +23,7 @@ protected function schedule(Schedule $schedule): void
             $schedule->command('lcm:post-article-to-telegram')->everyFourHours();
             $schedule->command('lcm:send-unverified-mails')->weeklyOn(1, '8:00');
             $schedule->command('sitemap:generate')->daily();
-            $schedule->command('lcm:notify-pending-articles')->days(2);
+            $schedule->command('lcm:notify-pending-articles')->cron('8 0 */2 * *');
         }
     }
 

app/Console/Commands/CreateAdminUser.php

@@ -11,7 +11,5 @@ final class ApiRegistered
 {
     use SerializesModels;
 
-    public function __construct(public User $user)
-    {
-    }
+    public function __construct(public User $user) {}
 }

app/Console/Commands/NotifyPendingArticles.php

@@ -11,7 +11,5 @@ final class ArticleWasSubmittedForApproval
 {
     use SerializesModels;
 
-    public function __construct(public Article $article)
-    {
-    }
+    public function __construct(public Article $article) {}
 }

app/Console/Kernel.php

@@ -12,7 +12,5 @@
 {
     use SerializesModels;
 
-    public function __construct(public Reply $reply, public Discussion $discussion)
-    {
-    }
+    public function __construct(public Reply $reply, public Discussion $discussion) {}
 }

app/Events/ApiRegistered.php

@@ -13,7 +13,5 @@ final class EmailAddressWasChanged
     use Dispatchable;
     use SerializesModels;
 
-    public function __construct(public User $user)
-    {
-    }
+    public function __construct(public User $user) {}
 }

app/Events/ArticleWasSubmittedForApproval.php

@@ -11,7 +11,5 @@ final class ReplyWasCreated
 {
     use SerializesModels;
 
-    public function __construct(public Reply $reply)
-    {
-    }
+    public function __construct(public Reply $reply) {}
 }

app/Events/CommentWasAdded.php

@@ -11,7 +11,5 @@ final class SponsoringPaymentInitialize
 {
     use SerializesModels;
 
-    public function __construct(public Transaction $transaction)
-    {
-    }
+    public function __construct(public Transaction $transaction) {}
 }

app/Events/EmailAddressWasChanged.php

@@ -11,7 +11,5 @@ final class ThreadWasCreated
 {
     use SerializesModels;
 
-    public function __construct(public Thread $thread)
-    {
-    }
+    public function __construct(public Thread $thread) {}
 }

app/Events/ReplyWasCreated.php

@@ -13,9 +13,7 @@ abstract class AbstractFilters
 
     protected array $filters = [];
 
-    public function __construct(public Request $request)
-    {
-    }
+    public function __construct(public Request $request) {}
 
     public function filter(Builder $builder): Builder
     {
@@ -35,7 +33,7 @@ public function add(array $filters): self
 
     public function resolverFilter(string $filter): mixed
     {
-        return new $this->filters[$filter]();
+        return new $this->filters[$filter];
     }
 
     public function getFilters(): array

app/Events/SponsoringPaymentInitialize.php

@@ -21,7 +21,6 @@ public function mappings(): array
 
     /**
      * @param  Builder<Thread>  $builder
-     * @param  mixed  $value
      * @return Builder<Thread>
      */
     public function filter(Builder $builder, mixed $value): Builder

app/Events/ThreadWasCreated.php

@@ -17,7 +17,7 @@ public function __invoke(ForgotPasswordRequest $request): JsonResponse
             $request->only('email')
         );
 
-        return Password::RESET_LINK_SENT === $status
+        return $status === Password::RESET_LINK_SENT
                     ? response()->json(['message' => __('L\'e-mail de réinitialisation du mot de passe a été envoyé avec succès !')])
                     : response()->json(['error' => __('Un courriel ne pourrait être envoyé à cette adresse électronique !')], 401);
     }

app/Filters/AbstractFilters.php

@@ -31,13 +31,13 @@ public function login(LoginRequest $request): JsonResponse
             'password' => $request->input('password'),
         ];
 
-        if ( ! $user || ! Auth::attempt($sanitized)) {
+        if (! $user || ! Auth::attempt($sanitized)) {
             throw ValidationException::withMessages([
                 'email' => __('Les informations d\'identification fournies sont incorrectes.'),
             ]);
         }
 
-        if ( ! $user->tokens()) {
+        if (! $user->tokens()) {
             $user->tokens()->delete();
         }