x

Author: eyurtsev

langchain_postgres/v2/async_vectorstore.py

@@ -802,7 +802,7 @@ async def aapply_vector_index(
         filter = f"WHERE ({index.partial_indexes})" if index.partial_indexes else ""
         params = "WITH " + index.index_options()
         if name is None:
-            if index.name == None:
+            if index.name is None:
                 index.name = self.table_name + DEFAULT_INDEX_NAME_SUFFIX
             name = index.name
         stmt = f'CREATE INDEX {"CONCURRENTLY" if concurrently else ""} "{name}" ON "{self.schema_name}"."{self.table_name}" USING {index.index_type} ({self.embedding_column} {function}) {params} {filter};'

tests/unit_tests/v2/test_async_pg_vectorstore.py

@@ -162,7 +162,7 @@ async def test_adelete(self, engine: PGEngine, vs: AsyncPGVectorStore) -> None:
         assert len(results) == 2
         # delete with no ids
         result = await vs.adelete()
-        assert result == False
+        assert not result
         await aexecute(engine, f'TRUNCATE TABLE "{DEFAULT_TABLE}"')
 
     ##### Custom Vector Store  #####

tests/unit_tests/v2/test_async_pg_vectorstore_index.py

@@ -123,4 +123,4 @@ async def test_aapply_vector_index_ivfflat(self, vs: AsyncPGVectorStore) -> None
 
     async def test_is_valid_index(self, vs: AsyncPGVectorStore) -> None:
         is_valid = await vs.is_valid_index("invalid_index")
-        assert is_valid == False
+        assert not is_valid

tests/unit_tests/v2/test_pg_vectorstore_index.py

@@ -116,7 +116,7 @@ async def test_aapply_vector_index_ivfflat(self, vs: PGVectorStore) -> None:
 
     async def test_is_valid_index(self, vs: PGVectorStore) -> None:
         is_valid = vs.is_valid_index("invalid_index")
-        assert is_valid == False
+        assert not is_valid
 
 
 @pytest.mark.enable_socket
@@ -178,4 +178,4 @@ async def test_aapply_vector_index_ivfflat(self, vs: PGVectorStore) -> None:
 
     async def test_is_valid_index(self, vs: PGVectorStore) -> None:
         is_valid = await vs.ais_valid_index("invalid_index")
-        assert is_valid == False
+        assert not is_valid

tests/unit_tests/v2/test_pg_vectorstore_search.py

@@ -398,6 +398,6 @@ def test_metadata_filter_negative_tests(
         self, vs_custom_filter_sync: PGVectorStore, test_filter: dict
     ) -> None:
         with pytest.raises((ValueError, NotImplementedError)):
-            docs = vs_custom_filter_sync.similarity_search(
+            vs_custom_filter_sync.similarity_search(
                 "meow", k=5, filter=test_filter
             )