Fixed an issue at Sync committee period change after second change

Author: rodrigo-o

lib/lambda_ethereum_consensus/validator/duties.ex

@@ -56,7 +56,7 @@ defmodule LambdaEthereumConsensus.Validator.Duties do
           ValidatorSet.validators()
         ) :: duties()
   def compute_duties_for_epochs(duties_map, epochs_and_start_slots, head_root, validators) do
-    Logger.info("[Duties] Computing duties for epochs: #{inspect(epochs_and_start_slots)}")
+    Logger.debug("[Duties] Computing duties for epochs: #{inspect(epochs_and_start_slots)}")
 
     for {epoch, slot} <- epochs_and_start_slots, reduce: duties_map do
       duties_map ->
@@ -73,7 +73,9 @@ defmodule LambdaEthereumConsensus.Validator.Duties do
         new_sync_committees =
           case sync_committee_compute_check(epoch, {last_epoch, Map.get(duties_map, last_epoch)}) do
             {:already_computed, sync_committees} -> sync_committees
-            :not_computed -> compute_current_sync_committees(beacon, validators)
+            {:not_computed, period} ->
+              Logger.debug("[Duties] Computing sync committees for period: #{period} and epoch: #{epoch}.")
+              compute_current_sync_committees(beacon, validators)
           end
 
         new_duties = %{
@@ -123,7 +125,7 @@ defmodule LambdaEthereumConsensus.Validator.Duties do
 
     if last_period == current_period,
       do: {:already_computed, last_duties.sync_committees},
-      else: :not_computed
+      else: {:not_computed, current_period}
   end
 
   @spec compute_attesters_for_epoch(BeaconState.t(), Types.epoch(), ValidatorSet.validators()) ::

lib/lambda_ethereum_consensus/validator/validator_set.ex

@@ -84,7 +84,7 @@ defmodule LambdaEthereumConsensus.ValidatorSet do
     |> update_state(epoch, slot, head_root)
     |> maybe_attests(epoch, slot, head_root)
     |> maybe_build_payload(slot + 1, head_root)
-    |> maybe_sync_committee_broadcasts(epoch, slot, head_root)
+    |> maybe_sync_committee_broadcasts(slot, head_root)
   end
 
   @doc """
@@ -111,7 +111,7 @@ defmodule LambdaEthereumConsensus.ValidatorSet do
     set
     |> maybe_attests(epoch, slot, head_root)
     |> maybe_build_payload(slot + 1, head_root)
-    |> maybe_sync_committee_broadcasts(epoch, slot, head_root)
+    |> maybe_sync_committee_broadcasts(slot, head_root)
   end
 
   defp process_tick(set, epoch, {slot, :last_third}) do
@@ -187,7 +187,10 @@ defmodule LambdaEthereumConsensus.ValidatorSet do
   ##############################
   # Sync committee
 
-  defp maybe_sync_committee_broadcasts(set, epoch, slot, head_root) do
+  defp maybe_sync_committee_broadcasts(set, slot, head_root) do
+    # Sync committee is broadcasted for the next slot, so we take the duties for the correct epoch.
+    epoch = Misc.compute_epoch_at_slot(slot + 1)
+
     case Duties.current_sync_committee(set.duties, epoch, slot) do
       [] ->
         set