Format and genesis_time addition to libp2p starts on tests

Author: rodrigo-o

lib/lambda_ethereum_consensus/beacon/clock.ex

@@ -12,6 +12,7 @@ defmodule LambdaEthereumConsensus.Beacon.Ticker do
 
   @spec register_to_tick(atom() | [atom()]) :: :ok
   def register_to_tick(to_tick) when is_atom(to_tick), do: register_to_tick([to_tick])
+
   def register_to_tick(to_tick) when is_list(to_tick) do
     GenServer.cast(__MODULE__, {:register_to_tick, to_tick})
   end
@@ -39,6 +40,12 @@ defmodule LambdaEthereumConsensus.Beacon.Ticker do
     schedule_next_tick()
     time = :os.system_time(:second)
 
+    # TODO: This assumes that on_tick/1 is implemented for all modules in to_tick
+    # this could be later a behaviour but I'm not sure we want to maintain this ticker
+    # in the long run. It's important that on_tick/1 is a very fast operation and
+    # that any intensive computation is done asynchronously (e.g calling a cast).
+    # We could also consider using a tasks to run on_tick/1 in parallel, but for
+    # now this is enough to avoid complexity.
     Enum.each(to_tick, & &1.on_tick(time))
 
     {:noreply, to_tick}

lib/lambda_ethereum_consensus/validator/duties.ex

@@ -69,7 +69,12 @@ defmodule LambdaEthereumConsensus.Validator.Duties do
     attester_duties
     # Drop the first element, which is the previous epoch's duty
     |> Stream.drop(1)
-    |> Enum.each(fn %{index_in_committee: i, committee_index: ci, slot: slot, should_aggregate?: sa} ->
+    |> Enum.each(fn %{
+                      index_in_committee: i,
+                      committee_index: ci,
+                      slot: slot,
+                      should_aggregate?: sa
+                    } ->
       Logger.info(
         "[Validator] #{validator_index} has to attest in committee #{ci} of slot #{slot} with index #{i}, and should_aggregate?: #{sa}"
       )

lib/lambda_ethereum_consensus/validator/validator.ex

@@ -246,7 +246,10 @@ defmodule LambdaEthereumConsensus.Validator do
     attestation = produce_attestation(current_duty, state.root, state.validator.privkey)
 
     log_md = [slot: attestation.data.slot, attestation: attestation, subnet_id: subnet_id]
-    debug_log_msg = "publishing attestation on committee index: #{current_duty.committee_index} | as #{current_duty.index_in_committee}/#{current_duty.committee_length - 1} and pubkey: #{LambdaEthereumConsensus.Utils.format_shorten_binary(validator.pubkey)}"
+
+    debug_log_msg =
+      "publishing attestation on committee index: #{current_duty.committee_index} | as #{current_duty.index_in_committee}/#{current_duty.committee_length - 1} and pubkey: #{LambdaEthereumConsensus.Utils.format_shorten_binary(validator.pubkey)}"
+
     log_debug(validator.index, debug_log_msg, log_md)
 
     Gossip.Attestation.publish(subnet_id, attestation)
@@ -303,7 +306,8 @@ defmodule LambdaEthereumConsensus.Validator do
       |> Stream.map(&Map.fetch!(&1, :aggregation_bits))
       |> Enum.reduce(&BitField.bitwise_or/2)
 
-    {:ok, signature} = unique_attestations |> Enum.map(&Map.fetch!(&1, :signature)) |> Bls.aggregate()
+    {:ok, signature} =
+      unique_attestations |> Enum.map(&Map.fetch!(&1, :signature)) |> Bls.aggregate()
 
     %{List.first(attestations) | aggregation_bits: aggregation_bits, signature: signature}
   end

lib/lambda_ethereum_consensus/validator/validator_manager.ex

@@ -47,8 +47,8 @@ defmodule LambdaEthereumConsensus.Validator.ValidatorManager do
     {:ok, validators}
   end
 
-  @spec notify_new_block(Types.slot(), Types.root()) :: :ok
-  def notify_new_block(slot, head_root) do
+  @spec notify_new_block({Types.slot(), Types.root()}) :: :ok
+  def notify_new_block({slot, head_root}) do
     # Making this alone a cast sometimes solves the issue for a while
     # GenServer.cast(__MODULE__, {:notify_all, {:new_block, slot, head_root}})
     notify_validators({:new_block, slot, head_root})

test/unit/beacon_api/beacon_api_v1_test.exs

@@ -159,7 +159,7 @@ defmodule Unit.BeaconApiTest.V1 do
     alias LambdaEthereumConsensus.P2P.Metadata
     patch(ForkChoice, :get_fork_version, fn -> ChainSpec.get("DENEB_FORK_VERSION") end)
 
-    start_link_supervised!(Libp2pPort)
+    start_link_supervised!({Libp2pPort, genesis_time: 42})
     Metadata.init()
     identity = Libp2pPort.get_node_identity()
     metadata = Metadata.get_metadata()

test/unit/libp2p_port_test.exs

@@ -17,7 +17,7 @@ defmodule Unit.Libp2pPortTest do
   end
 
   defp start_port(name \\ Libp2pPort, init_args \\ []) do
-    start_link_supervised!({Libp2pPort, [opts: [name: name]] ++ init_args}, id: name)
+    start_link_supervised!({Libp2pPort, [opts: [name: name], genesis_time: 42] ++ init_args}, id: name)
   end
 
   @tag :tmp_dir