Finally fixing the issue

Author: rodrigo-o

lib/lambda_ethereum_consensus/beacon/clock.ex

@@ -4,7 +4,6 @@ defmodule LambdaEthereumConsensus.Beacon.Clock do
   use GenServer
 
   alias LambdaEthereumConsensus.Libp2pPort
-  alias LambdaEthereumConsensus.Validator.ValidatorManager
 
   require Logger
 

lib/lambda_ethereum_consensus/validator/duties.ex

@@ -69,9 +69,9 @@ defmodule LambdaEthereumConsensus.Validator.Duties do
     attester_duties
     # Drop the first element, which is the previous epoch's duty
     |> Stream.drop(1)
-    |> Enum.each(fn %{index_in_committee: i, committee_index: ci, slot: slot} ->
-      Logger.debug(
-        "[Validator] #{validator_index} has to attest in committee #{ci} of slot #{slot} with index #{i}"
+    |> Enum.each(fn %{index_in_committee: i, committee_index: ci, slot: slot, should_aggregate?: sa} ->
+      Logger.info(
+        "[Validator] #{validator_index} has to attest in committee #{ci} of slot #{slot} with index #{i}, and should_aggregate?: #{sa}"
       )
     end)
 

lib/lambda_ethereum_consensus/validator/validator.ex

@@ -246,11 +246,11 @@ defmodule LambdaEthereumConsensus.Validator do
     attestation = produce_attestation(current_duty, state.root, state.validator.privkey)
 
     log_md = [slot: attestation.data.slot, attestation: attestation, subnet_id: subnet_id]
-    log_debug(validator.index, "publishing attestation", log_md)
+    debug_log_msg = "publishing attestation on committee index: #{current_duty.committee_index} | as #{current_duty.index_in_committee}/#{current_duty.committee_length - 1} and pubkey: #{LambdaEthereumConsensus.Utils.format_shorten_binary(validator.pubkey)}"
+    log_debug(validator.index, debug_log_msg, log_md)
 
-    # FIXME: Uncommenting this line generates the invalid signature errors upon proposals
-    # Gossip.Attestation.publish(subnet_id, attestation)
-    # |> log_info_result(validator.index, "published attestation", log_md)
+    Gossip.Attestation.publish(subnet_id, attestation)
+    |> log_info_result(validator.index, "published attestation", log_md)
 
     if current_duty.should_aggregate? do
       log_debug(validator.index, "collecting for future aggregation", log_md)
@@ -295,12 +295,15 @@ defmodule LambdaEthereumConsensus.Validator do
   end
 
   defp aggregate_attestations(attestations) do
+    # TODO: We need to check why we are producing duplicate attestations, this was generating invalid signatures
+    unique_attestations = attestations |> Enum.uniq()
+
     aggregation_bits =
-      attestations
+      unique_attestations
       |> Stream.map(&Map.fetch!(&1, :aggregation_bits))
       |> Enum.reduce(&BitField.bitwise_or/2)
 
-    {:ok, signature} = attestations |> Enum.map(&Map.fetch!(&1, :signature)) |> Bls.aggregate()
+    {:ok, signature} = unique_attestations |> Enum.map(&Map.fetch!(&1, :signature)) |> Bls.aggregate()
 
     %{List.first(attestations) | aggregation_bits: aggregation_bits, signature: signature}
   end

lib/lambda_ethereum_consensus/validator/validator_manager.ex

@@ -63,7 +63,7 @@ defmodule LambdaEthereumConsensus.Validator.ValidatorManager do
 
   # TODO: The use of a Genserver and cast is still needed to avoid locking at the clock level.
   # This is a temporary solution and will be taken off in a future PR.
-  defp notify_validators(msg), do: GenServer.call(__MODULE__, {:notify_all, msg})
+  defp notify_validators(msg), do: GenServer.call(__MODULE__, {:notify_all, msg}, 20_000)
 
   def handle_cast({:notify_all, msg}, validators) do
     validators = notify_all(validators, msg)
@@ -80,6 +80,8 @@ defmodule LambdaEthereumConsensus.Validator.ValidatorManager do
   defp notify_all(validators, msg) do
     start_time = System.monotonic_time(:millisecond)
 
+    Logger.info("[Validator Manager] Notifying all Validators with message: #{inspect(msg)}")
+
     updated_validators = Enum.map(validators, &notify_validator(&1, msg))
 
     end_time = System.monotonic_time(:millisecond)