Fix some warnings from compile and credo

Author: rodrigo-o

lib/lambda_ethereum_consensus/validator/duties.ex

@@ -80,40 +80,45 @@ defmodule LambdaEthereumConsensus.Validator.Duties do
           committee_index :: Types.uint64()
         ) :: [{Types.slot(), attester_duty()}]
   defp compute_attester_dutys(state, epoch, slot, validators, committee_index) do
-    with {:ok, committee} <- Accessors.get_beacon_committee(state, slot, committee_index) do
-      committee
-      |> Stream.with_index()
-      |> Stream.flat_map(fn {validator_index, index_in_committee} ->
-        case Map.get(validators, validator_index) do
-          nil ->
-            []
-
-          validator ->
-            [
-              %{
-                slot: slot,
-                validator_index: validator_index,
-                index_in_committee: index_in_committee,
-                committee_length: length(committee),
-                committee_index: committee_index,
-                attested?: false
-              }
-              |> update_with_aggregation_duty(state, validator.keystore.privkey)
-              |> update_with_subnet_id(state, epoch)
-            ]
-        end
-      end)
-      |> Enum.into([])
-      |> case do
-        [] -> []
-        duties -> [{slot, duties}]
-      end
-    else
+    case Accessors.get_beacon_committee(state, slot, committee_index) do
+      {:ok, committee} ->
+        compute_cometee_duties(state, epoch, slot, committee, committee_index, validators)
+
       {:error, _} ->
         []
     end
   end
 
+  defp compute_cometee_duties(state, epoch, slot, committee, committee_index, validators) do
+    committee
+    |> Stream.with_index()
+    |> Stream.flat_map(fn {validator_index, index_in_committee} ->
+      case Map.get(validators, validator_index) do
+        nil ->
+          []
+
+        validator ->
+          [
+            %{
+              slot: slot,
+              validator_index: validator_index,
+              index_in_committee: index_in_committee,
+              committee_length: length(committee),
+              committee_index: committee_index,
+              attested?: false
+            }
+            |> update_with_aggregation_duty(state, validator.keystore.privkey)
+            |> update_with_subnet_id(state, epoch)
+          ]
+      end
+    end)
+    |> Enum.into([])
+    |> case do
+      [] -> []
+      duties -> [{slot, duties}]
+    end
+  end
+
   defp check_valid_epoch(state, epoch) do
     next_epoch = Accessors.get_current_epoch(state) + 1
 

lib/lambda_ethereum_consensus/validator/validator.ex

@@ -540,7 +540,7 @@ defmodule LambdaEthereumConsensus.Validator do
   defp log_info(index, message, metadata \\ []),
     do: Logger.info("[Validator] #{index} #{message}", metadata)
 
-  defp log_debug(index, message, metadata \\ []),
+  defp log_debug(index, message, metadata),
     do: Logger.debug("[Validator] #{index} #{message}", metadata)
 
   defp log_error(index, message, reason, metadata \\ []),