Skip to content

Commit e0234d3

Browse files
authored
Merge pull request #2215 from showjason/replace-utcnow-with-now
replace utcnow with now, due to utcnow will be deprecated
2 parents 851dc2a + 07c94fb commit e0234d3

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

examples/deployment_crud.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,7 @@ def restart_deployment(api, deployment):
108108
# update `spec.template.metadata` section
109109
# to add `kubectl.kubernetes.io/restartedAt` annotation
110110
deployment.spec.template.metadata.annotations = {
111-
"kubectl.kubernetes.io/restartedAt": datetime.datetime.utcnow()
112-
.replace(tzinfo=pytz.UTC)
111+
"kubectl.kubernetes.io/restartedAt": datetime.datetime.now(tz=pytz.UTC)
113112
.isoformat()
114113
}
115114

examples/dynamic-client/deployment_rolling_restart.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ def main():
8484

8585
deployment_manifest["spec"]["template"]["metadata"] = {
8686
"annotations": {
87-
"kubectl.kubernetes.io/restartedAt": datetime.datetime.utcnow()
88-
.replace(tzinfo=pytz.UTC)
87+
"kubectl.kubernetes.io/restartedAt": datetime.datetime.now(tz=pytz.UTC)
8988
.isoformat()
9089
}
9190
}

kubernetes/base/config/kube_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def _create_temp_file_with_content(content, temp_file_path=None):
8080

8181
def _is_expired(expiry):
8282
return ((parse_rfc3339(expiry) - EXPIRY_SKEW_PREVENTION_DELAY) <=
83-
datetime.datetime.utcnow().replace(tzinfo=UTC))
83+
datetime.datetime.now(tz=UTC))
8484

8585

8686
class FileOrData(object):

kubernetes/base/config/kube_config_test.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
from kubernetes.client import Configuration
3131

3232
from .config_exception import ConfigException
33-
from .dateutil import format_rfc3339, parse_rfc3339
33+
from .dateutil import UTC, format_rfc3339, parse_rfc3339
3434
from .kube_config import (ENV_KUBECONFIG_PATH_SEPARATOR, CommandTokenSource,
3535
ConfigNode, FileOrData, KubeConfigLoader,
3636
KubeConfigMerger, _cleanup_temp_files,
@@ -89,10 +89,10 @@ def _raise_exception(st):
8989
TEST_PASSWORD = "pass"
9090
# token for me:pass
9191
TEST_BASIC_TOKEN = "Basic bWU6cGFzcw=="
92-
DATETIME_EXPIRY_PAST = datetime.datetime.utcnow(
93-
) - datetime.timedelta(minutes=PAST_EXPIRY_TIMEDELTA)
94-
DATETIME_EXPIRY_FUTURE = datetime.datetime.utcnow(
95-
) + datetime.timedelta(minutes=FUTURE_EXPIRY_TIMEDELTA)
92+
DATETIME_EXPIRY_PAST = datetime.datetime.now(tz=UTC
93+
).replace(tzinfo=None) - datetime.timedelta(minutes=PAST_EXPIRY_TIMEDELTA)
94+
DATETIME_EXPIRY_FUTURE = datetime.datetime.now(tz=UTC
95+
).replace(tzinfo=None) + datetime.timedelta(minutes=FUTURE_EXPIRY_TIMEDELTA)
9696
TEST_TOKEN_EXPIRY_PAST = _format_expiry_datetime(DATETIME_EXPIRY_PAST)
9797

9898
TEST_SSL_HOST = "https://test-host"
@@ -1028,7 +1028,7 @@ def test_load_gcp_token_no_refresh(self):
10281028
def test_load_gcp_token_with_refresh(self):
10291029
def cred(): return None
10301030
cred.token = TEST_ANOTHER_DATA_BASE64
1031-
cred.expiry = datetime.datetime.utcnow()
1031+
cred.expiry = datetime.datetime.now(tz=UTC).replace(tzinfo=None)
10321032

10331033
loader = KubeConfigLoader(
10341034
config_dict=self.TEST_KUBE_CONFIG,
@@ -1124,7 +1124,6 @@ def test_oidc_with_idp_ca_file_refresh(self, mock_ApiClient, mock_OAuth2Session)
11241124
active_context="expired_oidc_with_idp_ca_file",
11251125
)
11261126

1127-
11281127
self.assertTrue(loader._load_auth_provider_token())
11291128
self.assertEqual("Bearer abc123", loader.token)
11301129

@@ -1529,6 +1528,7 @@ def test_user_exec_auth_certificates(self, mock):
15291528
@mock.patch('kubernetes.config.kube_config.ExecProvider.run', autospec=True)
15301529
def test_user_exec_cwd(self, mock):
15311530
capture = {}
1531+
15321532
def capture_cwd(exec_provider):
15331533
capture['cwd'] = exec_provider.cwd
15341534
mock.side_effect = capture_cwd

0 commit comments

Comments
 (0)