From f7c6633cb6b71fa79506590ad1b93735165b076c Mon Sep 17 00:00:00 2001 From: cjihrig Date: Mon, 25 Nov 2024 20:23:14 -0500 Subject: [PATCH] ci: update action versions, test node 23, unpin node 20 This commit does the following: - Updates actions/checkout and actions/setup-node to v4 to avoid warning annotations when the test suite runs. - Adds Node v23 to the testing matrix since this is presently the Current release line. - Unpins the Node 20 version. The referenced GitHub issue is still open, but the tests seem to pass now. --- .github/workflows/test.yml | 45 +++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1c827db08f4..4f25d25aca6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,28 +1,27 @@ name: Kubernetes Javascript Client - Validation on: - push: - branches: [ master, release-1.x ] - pull_request: - branches: [ master, release-1.x ] + push: + branches: [master, release-1.x] + pull_request: + branches: [master, release-1.x] jobs: - build: - runs-on: ubuntu-latest - strategy: - matrix: - # Remove specific version from 20 when https://github.com/tschaub/mock-fs/issues/380 is fixed - node: [ '22', '20.7.0', '18' ] - name: Node ${{ matrix.node }} validation - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 - with: - node-version: ${{ matrix.node }} - # Pre-check to validate that versions match between package.json - # and package-lock.json. Needs to run before npm install - - run: node version-check.js - - run: npm ci - - run: npm test - - run: npm run lint - - run: npm audit --audit-level=critical + build: + runs-on: ubuntu-latest + strategy: + matrix: + node: ['23', '22', '20', '18'] + name: Node ${{ matrix.node }} validation + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node }} + # Pre-check to validate that versions match between package.json + # and package-lock.json. Needs to run before npm install + - run: node version-check.js + - run: npm ci + - run: npm test + - run: npm run lint + - run: npm audit --audit-level=critical