enforcing read-timeout for informer-factory processor to zero

Author: yue9944882

spring/src/main/java/io/kubernetes/client/spring/extended/controller/KubernetesInformerFactoryProcessor.java

@@ -17,10 +17,14 @@
 import io.kubernetes.client.informer.SharedInformer;
 import io.kubernetes.client.informer.SharedInformerFactory;
 import io.kubernetes.client.informer.cache.Lister;
+import io.kubernetes.client.informer.cache.ReflectorRunnable;
 import io.kubernetes.client.openapi.ApiClient;
 import io.kubernetes.client.spring.extended.controller.annotation.KubernetesInformer;
 import io.kubernetes.client.spring.extended.controller.annotation.KubernetesInformers;
+import io.kubernetes.client.spring.extended.controller.factory.KubernetesControllerFactory;
 import io.kubernetes.client.util.generic.GenericKubernetesApi;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.BeansException;
 import org.springframework.beans.factory.BeanFactory;
 import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
@@ -45,6 +49,8 @@ public class KubernetesInformerFactoryProcessor
 
   public static final int ORDER = 0;
 
+  private static final Logger log = LoggerFactory.getLogger(KubernetesControllerFactory.class);
+
   private ConfigurableListableBeanFactory beanFactory;
 
   @Override
@@ -122,6 +128,18 @@ private <T extends KubernetesObject> Lister<T> lister(Class<T> type) {
   private <T extends KubernetesObject> SharedInformer<T> informer(
       Class<T> type, KubernetesInformer kubernetesInformer) {
     ApiClient apiClient = this.beanFactory.getBean(ApiClient.class);
+
+    if (apiClient.getHttpClient().readTimeoutMillis() > 0) {
+      log.warn(
+          "Enforcing read-timeout of the ApiClient to zero so that the watch connection won't abort from client-side");
+      apiClient.setHttpClient(
+          apiClient
+              .getHttpClient()
+              .newBuilder()
+              .readTimeout(ReflectorRunnable.REFLECTOR_WATCH_CLIENTSIDE_TIMEOUT)
+              .build());
+    }
+
     SharedInformerFactory sharedInformerFactory =
         this.beanFactory.getBean(SharedInformerFactory.class);
     final GenericKubernetesApi api =

util/src/main/java/io/kubernetes/client/informer/cache/ReflectorRunnable.java

@@ -37,6 +37,8 @@ public class ReflectorRunnable<
         ApiType extends KubernetesObject, ApiListType extends KubernetesListObject>
     implements Runnable {
 
+  public static Duration REFLECTOR_WATCH_CLIENTSIDE_TIMEOUT = Duration.ofMinutes(5);
+
   private static final Logger log = LoggerFactory.getLogger(ReflectorRunnable.class);
 
   private String lastSyncResourceVersion;
@@ -113,7 +115,7 @@ public void run() {
                   new CallGeneratorParams(
                       Boolean.TRUE,
                       lastSyncResourceVersion,
-                      Long.valueOf(Duration.ofMinutes(5).getSeconds()).intValue()));
+                      Long.valueOf(REFLECTOR_WATCH_CLIENTSIDE_TIMEOUT.getSeconds()).intValue()));
 
           synchronized (this) {
             if (!isActive.get()) {