Add unit test

Author: admilazz

src/KubernetesClient/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo("KubernetesClient.Tests, PublicKey=00240000048000009400000006020000002400005253413100040000010001004917ad4e106c573cc5dbb3b7456de8b6c07128ae43de292752b339eb423de60f0db6a6c0cb21e6640fc672cc84df4a772db85df1505e5dd08c98d5d115eed7a7b59c67fe1f4b32fa716b7177743a417b3fcf88606861650a81f565ac6614abbf8b6b7710436edb497a83974165f9fe6995b70af13047a110bf63cdbfa45f89ac")]

src/KubernetesClient/Utilities.cs

@@ -8,10 +8,10 @@ internal static class Utilities
         /// <summary>Given a <see cref="StringBuilder"/> that is building a query string, adds a parameter to it.</summary>
         public static void AddQueryParameter(StringBuilder sb, string key, string value)
         {
-            if(sb == null) throw new ArgumentNullException(nameof(sb));
-            if(string.IsNullOrEmpty(key)) throw new ArgumentNullException(nameof(key));
+            if (sb == null) throw new ArgumentNullException(nameof(sb));
+            if (string.IsNullOrEmpty(key)) throw new ArgumentNullException(nameof(key));
             sb.Append(sb.Length != 0 ? '&' : '?').Append(Uri.EscapeDataString(key)).Append('=');
-            if(!string.IsNullOrEmpty(value)) sb.Append(Uri.EscapeDataString(value));
+            if (!string.IsNullOrEmpty(value)) sb.Append(Uri.EscapeDataString(value));
         }
     }
 }

tests/KubernetesClient.Tests/KubernetesClient.Tests.csproj

@@ -2,6 +2,8 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <RootNamespace>k8s.Tests</RootNamespace>
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>../../src/KubernetesClient/kubernetes-client.snk</AssemblyOriginatorKeyFile>
     <TargetFrameworks>netcoreapp2.1;netcoreapp2.0</TargetFrameworks>
   </PropertyGroup>
 

tests/KubernetesClient.Tests/UtilityTests.cs

@@ -0,0 +1,24 @@
+using System;
+using System.Text;
+using Xunit;
+
+namespace k8s.Tests
+{
+    public class UtilityTests
+    {
+        [Fact]
+        public void TestQueryStringUtilities()
+        {
+            var sb = new StringBuilder();
+            Assert.Throws<ArgumentNullException>(() => Utilities.AddQueryParameter(null, "key", "value"));
+            Assert.Throws<ArgumentNullException>(() => Utilities.AddQueryParameter(sb, null, "value"));
+            Assert.Throws<ArgumentNullException>(() => Utilities.AddQueryParameter(sb, "", "value"));
+
+            Utilities.AddQueryParameter(sb, "key", "value");
+            Utilities.AddQueryParameter(sb, "key", "a=b");
+            Utilities.AddQueryParameter(sb, "+key", null);
+            Utilities.AddQueryParameter(sb, "ekey", "");
+            Assert.Equal("?key=value&key=a%3Db&%2Bkey=&ekey=", sb.ToString());
+        }
+    }
+}