Skip to content

Commit 08102a2

Browse files
committed
Address review comments
1 parent 38a06ab commit 08102a2

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

docs/src/submodules/Bridges/list_of_bridges.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,5 @@ Bridges.Variable.RSOCtoSOCBridge
8484
Bridges.Variable.SOCtoRSOCBridge
8585
Bridges.Variable.VectorizeBridge
8686
Bridges.Variable.ZerosBridge
87+
Bridges.Variable.HermitianToSymmetricPSDBridge
8788
```

src/Bridges/Variable/bridges/hermitian.jl

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
# Use of this source code is governed by an MIT-style license that can be found
55
# in the LICENSE.md file or at https://opensource.org/licenses/MIT.
66

7-
const EQ{T} = MOI.ConstraintIndex{MOI.ScalarAffineFunction{T},MOI.EqualTo{T}}
8-
97
"""
108
HermitianToSymmetricPSDBridge{T} <: Bridges.Variable.AbstractBridge
119
@@ -72,9 +70,15 @@ struct HermitianToSymmetricPSDBridge{T} <: AbstractBridge
7270
MOI.VectorOfVariables,
7371
MOI.PositiveSemidefiniteConeTriangle,
7472
}
75-
con_11_22::Vector{EQ{T}}
76-
con12diag::Vector{EQ{T}}
77-
con_12_21::Vector{EQ{T}}
73+
con_11_22::Vector{
74+
MOI.ConstraintIndex{MOI.ScalarAffineFunction{T},MOI.EqualTo{T}},
75+
}
76+
con12diag::Vector{
77+
MOI.ConstraintIndex{MOI.ScalarAffineFunction{T},MOI.EqualTo{T}},
78+
}
79+
con_12_21::Vector{
80+
MOI.ConstraintIndex{MOI.ScalarAffineFunction{T},MOI.EqualTo{T}},
81+
}
7882
end
7983

8084
const HermitianToSymmetricPSD{T,OT<:MOI.ModelLike} =
@@ -104,9 +108,12 @@ function bridge_constrained_variable(
104108
return variables[k21]
105109
end
106110
X22() = variables[k22]
107-
con_11_22 = EQ{T}[]
108-
con12diag = EQ{T}[]
109-
con_12_21 = EQ{T}[]
111+
con_11_22 =
112+
MOI.ConstraintIndex{MOI.ScalarAffineFunction{T},MOI.EqualTo{T}}[]
113+
con12diag =
114+
MOI.ConstraintIndex{MOI.ScalarAffineFunction{T},MOI.EqualTo{T}}[]
115+
con_12_21 =
116+
MOI.ConstraintIndex{MOI.ScalarAffineFunction{T},MOI.EqualTo{T}}[]
110117
for j in 1:n
111118
k22 += n
112119
for i in 1:j
@@ -153,9 +160,6 @@ function bridge_constrained_variable(
153160
)
154161
end
155162

156-
const HermitianToSymmetricPSD{T,OT<:MOI.ModelLike} =
157-
SingleBridgeOptimizer{HermitianToSymmetricPSDBridge{T},OT}
158-
159163
function supports_constrained_variable(
160164
::Type{<:HermitianToSymmetricPSDBridge},
161165
::Type{MOI.HermitianPositiveSemidefiniteConeTriangle},

0 commit comments

Comments
 (0)