Skip to content

added missing testcase for no-ununsed-prop rule #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

himanshu007-creator
Copy link
Contributor

resolves #3336

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #3463 (6073df0) into master (bf59919) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3463   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         127      127           
  Lines        9066     9066           
  Branches     3307     3307           
=======================================
  Hits         8843     8843           
  Misses        223      223           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to find a way to run this test case with a custom tsconfig that contains:

{
  "compilerOptions": {
    "jsx": "react-jsx",
  },
}

@ljharb ljharb force-pushed the master branch 6 times, most recently from 59af733 to 865ed16 Compare November 11, 2022 02:45
@himanshu007-creator
Copy link
Contributor Author

Will rework, closing for now

@ljharb
Copy link
Member

ljharb commented Nov 16, 2022

@himanshu007-creator it'd be great to reopen this, otherwise the PR isn't going to be recoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bug: no-unused-prop-types doesn't detect unused props with Typescript & React 17 jsx transform
2 participants