Skip to content

[Fix] boolean-prop-naming: add missing default config #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix] boolean-prop-naming: add missing default config #1702

wants to merge 1 commit into from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Feb 24, 2018 •
edited
Loading

This might be semver-major, since the rule has never had any default behavior previously.

Fixes #1551. Probably fixes #1540.

@ljharb
[Fix] boolean-prop-naming: add missing default config
28843f7 
This might be semver-major, since the rule has never had any default
behavior previously.

Fixes jsx-eslint#1551.
@ljharb ljharb force-pushed the fix_boolean_prop_naming branch from e26e595 to 28843f7 Compare February 24, 2018 21:53
EvHaus
EvHaus approved these changes Feb 25, 2018
View reviewed changes
Copy link
Collaborator

@EvHaus EvHaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree that semver should be considered as we don't want users to complain about the unexpected change.

@ljharb
Copy link
Member Author

ljharb commented Feb 25, 2018

In that case we can leave this unmerged for awhile until we’re ready for a breaking change.

@ljharb ljharb removed the question label Mar 14, 2018
@ljharb ljharb added the semver-major Breaking change. label Dec 27, 2018
@jordanbtucker jordanbtucker mentioned this pull request Mar 6, 2019
Open
@ljharb ljharb force-pushed the master branch 6 times, most recently from 59af733 to 865ed16 Compare November 11, 2022 02:45
@ljharb ljharb force-pushed the master branch 4 times, most recently from 069314a to 181c68f Compare November 18, 2022 17:19
@ljharb ljharb force-pushed the master branch 2 times, most recently from 380e32c to 51d342b Compare July 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannickcr yannickcr yannickcr approved these changes

@lencioni lencioni lencioni approved these changes

@EvHaus EvHaus EvHaus approved these changes

@louisscruz louisscruz louisscruz approved these changes

Assignees
No one assigned
Labels
bug semver-major Breaking change.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boolean-prop-naming is missing default config boolean-prop-naming does not check Flow props
5 participants
@ljharb @yannickcr @lencioni @EvHaus @louisscruz