Remove array destructuring

Author: Pearce-Ropion

lib/rules/jsx-no-literals.js

@@ -142,8 +142,13 @@ function normalizeConfig(config, handleElementOverrides) {
       normalizedConfig.elementOverrides = fromEntries(
         reduce(
           iterFrom(entries(config.elementOverrides)),
-          (acc, [key, value]) => {
+          (acc, entry) => {
+            const key = entry[0];
+            const value = entry[1];
+            
+            if (!(key && value)) return acc;
             if (!reOverridableElement.test(key)) return acc;
+
             acc.push([
               key,
               Object.assign(normalizeConfig(value, false), {
@@ -241,12 +246,15 @@ module.exports = {
      * Gets the name of the given JSX element. Supports nested
      * JSXMemeberExpressions. ie `<Namesapce.Component.SubComponent />`
      * @param {ASTNode} node
-     * @returns {(string | undefined)[] | undefined}
+     * @returns {{ name: string; compoundName: string | undefined } | undefined}
      */
     function getJSXElementName(node) {
       if (node.openingElement.name.type === 'JSXIdentifier') {
         const name = node.openingElement.name.name;
-        return [renamedImportMap.get(name) || name, undefined];
+        return {
+          name: renamedImportMap.get(name) || name,
+          compoundName: undefined,
+        }
       }
 
       /** @type {string[]} */
@@ -276,7 +284,10 @@ module.exports = {
 
           const nameFragment = nameFragments[nameFragments.length - 1];
           if (nameFragment) {
-            return [nameFragment, nameFragments.join('.')];
+            return {
+              name: nameFragment,
+              compoundName: nameFragments.join('.'),
+            }
           }
         }
       }
@@ -377,16 +388,15 @@ module.exports = {
       const allAncestorElements = getJSXElementAncestors(node);
       if (!allAncestorElements.length) return;
 
-      for (const ancestor of allAncestorElements) {
-        const isClosestJSXAncestor = ancestor === allAncestorElements[0];
+      for (const ancestorElement of allAncestorElements) {
+        const isClosestJSXAncestor = ancestorElement === allAncestorElements[0];
 
-        const elementNames = getJSXElementName(ancestor);
-        if (elementNames && Array.isArray(elementNames) && elementNames.length === 2) {
-          const [ancestorName, compoundAncestorName] = elementNames;
-          if (ancestorName) {
-            const ancestorConfig = compoundAncestorName
-              ? config.elementOverrides[compoundAncestorName] || config.elementOverrides[ancestorName]
-              : config.elementOverrides[ancestorName];
+        const ancestor = getJSXElementName(ancestorElement);
+        if (ancestor) {
+          if (ancestor.name) {
+            const ancestorConfig = ancestor.compoundName
+              ? config.elementOverrides[ancestor.compoundName] || config.elementOverrides[ancestor.name]
+              : config.elementOverrides[ancestor.name];
 
             if (ancestorConfig) {
               if (isClosestJSXAncestor || ancestorConfig.applyToNestedElements) {