fix: error when use object rest properties

Author: nix6839

lib/rules/require-default-props.js

@@ -123,18 +123,19 @@ module.exports = {
             break;
           }
           case 'ObjectPattern': {
-            props.properties.forEach((prop) => {
-              const propName = prop.key.name;
-              const propType = propTypes[propName];
-              if (!propType || propType.isRequired) {
-                return;
+            props.properties.filter((prop) => {
+              if (prop.type === 'RestElement') {
+                return false;
               }
-              if (prop.value.type === 'AssignmentPattern') {
-                return;
+              const propType = propTypes[prop.key.name];
+              if (!propType || propType.isRequired) {
+                return false;
               }
+              return prop.value.type !== 'AssignmentPattern';
+            }).forEach((prop) => {
               report(context, messages.shouldAssignObjectDefault, 'shouldAssignObjectDefault', {
                 node: prop,
-                data: { name: propName },
+                data: { name: prop.key.name },
               });
             });
             break;

tests/lib/rules/require-default-props.js

@@ -261,6 +261,34 @@ ruleTester.run('require-default-props', rule, {
       `,
       options: [{ forceDefaultPropArguments: true }],
     },
+    {
+      code: `
+        function MyStatelessComponent({ foo, bar = 'asdf', ...props }) {
+          return <div>{foo}{bar}</div>;
+        }
+        MyStatelessComponent.propTypes = {
+          foo: PropTypes.string.isRequired,
+          bar: PropTypes.string,
+          hello: PropTypes.string.isRequired,
+          world: PropTypes.string.isRequired
+        }
+      `,
+      options: [{ forceDefaultPropArguments: true }],
+    },
+    {
+      code: `
+        function MyStatelessComponent({ foo, bar, ...props }) {
+          return <div>{foo}{bar}</div>;
+        }
+        MyStatelessComponent.propTypes = {
+          foo: PropTypes.string.isRequired,
+          bar: PropTypes.string.isRequired,
+          hello: PropTypes.string.isRequired,
+          world: PropTypes.string.isRequired
+        }
+      `,
+      options: [{ forceDefaultPropArguments: true }],
+    },
 
     // stateless components as function expressions
     {
@@ -1346,6 +1374,27 @@ ruleTester.run('require-default-props', rule, {
         },
       ],
     },
+    {
+      code: `
+        function MyStatelessComponent({ foo, bar, ...props }) {
+          return <div>{foo}{bar}</div>;
+        }
+        MyStatelessComponent.propTypes = {
+          foo: PropTypes.string,
+          bar: PropTypes.string.isRequired,
+          hello: PropTypes.string.isRequired,
+          world: PropTypes.string.isRequired
+        }
+      `,
+      options: [{ forceDefaultPropArguments: true }],
+      errors: [
+        {
+          messageId: 'shouldAssignObjectDefault',
+          line: 2,
+          column: 41,
+        },
+      ],
+    },
 
     // createReactClass components
     {