Add tests, fix bug with disallowList on components

Yay tests

Author: Ell Bradshaw

lib/rules/forbid-component-props.js

@@ -82,7 +82,7 @@ module.exports = {
 
       const propName = typeof value === 'string' ? value : value.propName;
       const options = {
-        allowList: typeof value === 'string' ? [] : (value.allowedFor || []),
+        allowList: typeof value === 'string' ? null : (value.allowedFor || null),
         disallowList: typeof value === 'string' ? null : (value.disallowedFor || null),
         message: typeof value === 'string' ? null : value.message,
       };

tests/lib/rules/forbid-component-props.js

@@ -151,6 +151,36 @@ ruleTester.run('forbid-component-props', rule, {
         },
       ],
     },
+    {
+      code: `
+        const item = (<Foo className="foo" />);
+      `,
+      options: [
+        {
+          forbid: [
+            {
+              propName: 'className',
+              disallowedFor: ['ReactModal'],
+            },
+          ],
+        },
+      ],
+    },
+    {
+      code: `
+        const item = (<Foo className="foo" />);
+      `,
+      options: [
+        {
+          forbid: [
+            {
+              propName: 'className',
+              disallowedFor: ['ReactModal'],
+            },
+          ],
+        },
+      ],
+    },
     {
       code: `
         <fbt:param name="Total number of files" number={true} />
@@ -282,6 +312,54 @@ ruleTester.run('forbid-component-props', rule, {
         },
       ],
     },
+    {
+      code: `
+        const item = (<ReactModal className="foo" />);
+      `,
+      options: [
+        {
+          forbid: [
+            {
+              propName: 'className',
+              disallowedFor: ['ReactModal'],
+            },
+          ],
+        },
+      ],
+      errors: [
+        {
+          messageId: 'propIsForbidden',
+          data: { prop: 'className' },
+          line: 2,
+          column: 35,
+          type: 'JSXAttribute',
+        },
+      ],
+    },
+    {
+      code: `
+        const item = (<AntdLayout.Content className="antdFoo" />);
+      `,
+      options: [
+        {
+          forbid: [
+            {
+              propName: 'className',
+              disallowedFor: ['AntdLayout.Content'],
+            },
+          ],
+        },
+      ],
+      errors: [
+        {
+          messageId: 'propIsForbidden',
+          data: { prop: 'className' },
+          line: 2,
+          column: 43,
+          type: 'JSXAttribute',
+        },
+      ],
+    },
     {
       code: `
         const item = (<Foo className="foo" />);

tests/lib/rules/forbid-dom-props.js

@@ -112,6 +112,23 @@ ruleTester.run('forbid-dom-props', rule, {
         },
       ],
     },
+    {
+      code: `
+        const First = (props) => (
+          <span otherProp="bar" />
+        );
+      `,
+      options: [
+        {
+          forbid: [
+            {
+              propName: 'otherProp',
+              allowedFor: ['span'],
+            },
+          ],
+        },
+      ],
+    },
   ]),
 
   invalid: parsers.all([