Better fixer for conditional

Author: Joachim Seminck

lib/rules/jsx-wrap-multilines.js

@@ -70,7 +70,7 @@ module.exports = {
       return node.loc.start.line !== node.loc.end.line;
     }
 
-    function check(node) {
+    function check(node, fixerFn) {
       if (!node || node.type !== 'JSXElement') {
         return;
       }
@@ -79,7 +79,7 @@ module.exports = {
         context.report({
           node: node,
           message: 'Missing parentheses around multilines JSX',
-          fix: function(fixer) {
+          fix: fixerFn || function(fixer) {
             return fixer.replaceText(node, `(${sourceCode.getText(node)})`);
           }
         });
@@ -135,7 +135,14 @@ module.exports = {
           return;
         }
 
-        check(node.expression.right);
+        const rightNode = node.expression.right;
+
+        check(rightNode, (fixer) => {
+          return [
+            fixer.insertTextAfterRange(sourceCode.getTokenBefore(rightNode).range, ' ('),
+            fixer.insertTextBeforeRange(sourceCode.getLastToken(node).range, ')')
+          ];
+        });
       },
 
       'ArrowFunctionExpression:exit': function (node) {

tests/lib/rules/jsx-wrap-multilines.js

@@ -141,16 +141,6 @@ const CONDITIONAL_SINGLE_LINE = `
 `;
 
 const CONDITIONAL_PAREN = `
-  <div>
-    {unreadMessages.length > 0 &&
-      (<h2>
-        You have {unreadMessages.length} unread messages.
-      </h2>)
-    }
-  </div>
-`;
-
-const CONDITIONAL_PAREN_DIFFERENT_LINE = `
   <div>
     {unreadMessages.length > 0 && (
       <h2>
@@ -228,9 +218,6 @@ ruleTester.run('jsx-wrap-multilines', rule, {
     }, {
       code: CONDITIONAL_PAREN,
       options: [{conditional: true}]
-    }, {
-      code: CONDITIONAL_PAREN_DIFFERENT_LINE,
-      options: [{conditional: true}]
     }, {
       code: CONDITIONAL_SINGLE_LINE,
       options: [{conditional: true}]