fix: fixing code structure

Author: himanshu007-creator

lib/rules/no-invalid-html-attribute.js

@@ -247,6 +247,21 @@ const fixMessages = {
   removeWhitespaces: 'remove whitespaces in “{{reportingValue}}”',
 }
 
+function fix (fixer, mode, ...args) {
+  if (mode === 'removeTextRange') {
+    return fixer.replaceTextRange(args)
+  }
+  if (mode === 'removeRange') {
+    return fixer.removeRange(args)
+  }
+    return fixer.remove(args)
+}
+
+function suggestion(desc, mode, ...args) {
+  return {desc: desc, ...fix(mode, args)}
+}
+
+
 function splitIntoRangedParts(node, regex) {
   const valueRangeStart = node.range[0] + 1; // the plus one is for the initial quote
 
@@ -267,7 +282,7 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
     report(context, messages.onlyStrings, 'onlyStrings', {
       node,
       data: { attributeName },
-      suggestion(fixMessages.removeNonString, fixer, fixModes.remove, parentNode)
+      suggestion :suggestion(fixMessages.removeNonString,fixModes.remove, parentNode)
     });
     return;
   }
@@ -276,7 +291,7 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
     report(context, messages.noEmpty, 'noEmpty', {
       node,
       data: { attributeName },
-      suggestion(fixMessages.removeEmpty, fixer, fixModes.remove, attributeName)
+      suggestion :suggestion(fixMessages.removeEmpty, fixModes.remove, attributeName)
     });
     return;
   }
@@ -292,7 +307,7 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
           attributeName,
           reportingValue,
         },
-        suggestion(fixMessages.removeInvalid, fixer, fixModes.removeRange, singlePart.range)
+        suggestion :suggestion(fixMessages.removeInvalid, fixModes.removeRange, singlePart.range)
       });
     } else if (!allowedTags.has(parentNodeName)) {
       report(context, messages.notValidFor, 'notValidFor', {
@@ -302,7 +317,7 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
           reportingValue,
           elementName: parentNodeName,
         },
-        suggestion(fixMessages.removeInvalid, fixer, fixModes.removeRange, singlePart.range)
+        suggestion :suggestion(fixMessages.removeInvalid, fixModes.removeRange, singlePart.range)
       });
     }
   }
@@ -342,13 +357,13 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
       report(context, messages.spaceDelimited, 'spaceDelimited', {
         node,
         data: { attributeName },
-        suggestion(fixMessages.removeWhitespaces, fixer, fixModes.removeRange, whitespacePart.range)
+        suggestion :suggestion(fixMessages.removeWhitespaces, fixModes.removeRange, whitespacePart.range)
       });
     } else if (whitespacePart.value !== '\u0020') {
       report(context, messages.spaceDelimited, 'spaceDelimited', {
         node,
         data: { attributeName },
-        suggestion(fixMessages.removeWhitespaces, fixer, mofixModes.replaceTextRange, whitespacePart.range, '\u0020' )
+        suggestion :suggestion(fixMessages.removeWhitespaces, fixModes.replaceTextRange, whitespacePart.range, '\u0020' )
       });
     }
   }
@@ -359,25 +374,7 @@ const DEFAULT_ATTRIBUTES = ['rel'];
 function checkAttribute(context, node) {
   const attribute = node.name.name;
 
-  function fix(fixer, mode, ...args) {
-    if (mode === 'removeTextRange') {
-      return fixer.replaceTextRange(args)
-    }
-    if (mode === 'removeRange') {
-      return fixer.removeRange(args)
-    }
-      return fixer.remove(args)
-  }
-
-  function suggestion(desc, fixer, mode, ...args) {
-    return [
-      {
-        desc: desc,
-        fix(fixer, mode, args)
-      }
-    ]
-  }
-
+ 
   const parentNodeName = node.parent.name.name;
   if (!COMPONENT_ATTRIBUTE_MAP.has(attribute) || !COMPONENT_ATTRIBUTE_MAP.get(attribute).has(parentNodeName)) {
     const tagNames = Array.from(
@@ -390,7 +387,7 @@ function checkAttribute(context, node) {
         attributeName: attribute,
         tagNames,
       },
-      suggestion(fixMessages.removeDefault, fixer, fixModes.remove, attributeName)
+      suggestion :suggestion(fixMessages.removeDefault, fixModes.remove, attribute)
     });
     return;
   }
@@ -399,7 +396,7 @@ function checkAttribute(context, node) {
     report(context, messages.emptyIsMeaningless, 'emptyIsMeaningless', {
       node,
       data: { attributeName: attribute },
-      suggestion(fixMessages.removeEmpty, fixer, fixModes.removemode, attributeName)
+      suggestion :suggestion(fixMessages.removeEmpty, fixModes.removemode, node)
     });
     return;
   }
@@ -420,7 +417,7 @@ function checkAttribute(context, node) {
     report(context, messages.onlyStrings, 'onlyStrings', {
       node,
       data: { attributeName: attribute },
-      suggestion(fixMessages.removeDefault, fixer, fixModes.remove, attributeName)
+      suggestion :suggestion(fixMessages.removeDefault, fixModes.remove, node)
     });
     return;
   }
@@ -429,7 +426,7 @@ function checkAttribute(context, node) {
     report(context, messages.onlyStrings, 'onlyStrings', {
       node,
       data: { attributeName: attribute },
-      suggestion(fixMessages.removeDefault fixer, fixModes.remove, attributeName)
+      suggestion :suggestion(fixMessages.removeDefault, fixModes.remove, node)
     });
   }
 }