Add support for wrapped propTypes to forbid-prop-types

Author: dustinsoftware

lib/rules/forbid-prop-types.js

@@ -36,6 +36,8 @@ module.exports = {
   },
 
   create: function(context) {
+    var propWrapperFunctions = new Set(context.settings.propWrapperFunctions || []);
+
     function isForbidden(type) {
       var configuration = context.options[0] || {};
 
@@ -108,17 +110,46 @@ module.exports = {
 
     return {
       ClassProperty: function(node) {
-        if (isPropTypesDeclaration(node) && node.value && node.value.type === 'ObjectExpression') {
-          checkForbidden(node.value.properties);
+        if (!isPropTypesDeclaration(node)) {
+          return;
+        }
+        switch (node.value && node.value.type) {
+          case 'ObjectExpression':
+            checkForbidden(node.value.properties);
+            break;
+          case 'CallExpression':
+            if (
+              propWrapperFunctions.has(node.value.callee.name) &&
+              node.value.arguments && node.value.arguments[0]
+            ) {
+              checkForbidden(node.value.arguments[0].properties);
+            }
+            break;
+          default:
+            break;
         }
       },
 
       MemberExpression: function(node) {
-        if (isPropTypesDeclaration(node.property)) {
-          var right = node.parent.right;
-          if (right && right.type === 'ObjectExpression') {
+        if (!isPropTypesDeclaration(node.property)) {
+          return;
+        }
+
+        var right = node.parent.right;
+        switch (right && right.type) {
+          case 'ObjectExpression':
             checkForbidden(right.properties);
-          }
+            break;
+          case 'CallExpression':
+            if (
+              propWrapperFunctions.has(right.callee.name) &&
+              right.arguments && right.arguments[0]
+            ) {
+              checkForbidden(right.arguments[0].properties);
+            }
+            break;
+          default:
+            break;
         }
       },
 

tests/lib/rules/forbid-prop-types.js

@@ -383,6 +383,21 @@ ruleTester.run('forbid-prop-types', rule, {
       '};'
     ].join('\n'),
     errors: 4
+  }, {
+    code: [
+      'class First extends React.Component {',
+      '  render() {',
+      '    return <div />;',
+      '  }',
+      '}',
+      'First.propTypes = forbidExtraProps({',
+      '    a: PropTypes.array',
+      '});'
+    ].join('\n'),
+    errors: 1,
+    settings: {
+      propWrapperFunctions: ['forbidExtraProps']
+    }
   }, {
     code: [
       'class Component extends React.Component {',
@@ -397,6 +412,23 @@ ruleTester.run('forbid-prop-types', rule, {
     ].join('\n'),
     parser: 'babel-eslint',
     errors: 2
+  }, {
+    code: [
+      'class Component extends React.Component {',
+      '  static propTypes = forbidExtraProps({',
+      '    a: PropTypes.array,',
+      '    o: PropTypes.object',
+      '  });',
+      '  render() {',
+      '    return <div />;',
+      '  }',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    errors: 2,
+    settings: {
+      propWrapperFunctions: ['forbidExtraProps']
+    }
   }, {
     code: [
       'var Hello = createReactClass({',