feat: change option working

- Rename option `forceDefaultPropArguments` to `functions`.
- The option has value `'defaultProps' | 'defaultArguments' | 'ignore'`.
- Add `classes` option but now works as before.

Author: nix6839

lib/rules/require-default-props.js

@@ -40,10 +40,24 @@ module.exports = {
         forbidDefaultForRequired: {
           type: 'boolean',
         },
-        ignoreFunctionalComponents: {
-          type: 'boolean',
+        /**
+         * For now, this wouldn't support any other choices, and would be optional,
+         * but later could be set to "ignore" as long as `functions` wasn't set to "ignore"
+         */
+        classes: {
+          allow: {
+            enum: ['defaultProps'],
+          },
+        },
+        functions: {
+          allow: {
+            enum: ['defaultArguments', 'defaultProps', 'ignore'],
+          },
         },
-        forceDefaultPropArguments: {
+        /**
+         * @deprecated
+         */
+        ignoreFunctionalComponents: {
           type: 'boolean',
         },
       },
@@ -54,8 +68,14 @@ module.exports = {
   create: Components.detect((context, components) => {
     const configuration = context.options[0] || {};
     const forbidDefaultForRequired = configuration.forbidDefaultForRequired || false;
-    const ignoreFunctionalComponents = configuration.ignoreFunctionalComponents || false;
-    const forceDefaultPropArguments = configuration.forceDefaultPropArguments || false;
+    /**
+     * @todo
+     * - Remove ignoreFunctionalComponents
+     * - Change default to 'defaultArguments'
+     */
+    const functions = configuration.ignoreFunctionalComponents
+      ? 'ignore'
+      : configuration.functions || 'defaultProps';
 
     /**
      * Reports all propTypes passed in that don't have a defaultProps counterpart.
@@ -90,7 +110,7 @@ module.exports = {
     }
 
     /**
-     * If forceDefaultPropArguments options is true, reports defaultProps is used and all params that doesn't initialized.
+     * If functions option is 'defaultArguments', reports defaultProps is used and all params that doesn't initialized.
      * @param {Object} componentNode Node of component.
      * @param {Object[]} declaredPropTypes List of propTypes to check `isRequired`.
      * @param {Object} defaultProps Object of defaultProps to check used.
@@ -155,9 +175,7 @@ module.exports = {
         const list = components.list();
 
         values(list).filter((component) => {
-          if (ignoreFunctionalComponents
-              && astUtil.isFunctionLike(component.node)
-          ) {
+          if (functions === 'ignore' && astUtil.isFunctionLike(component.node)) {
             return false;
           }
           // If this defaultProps is "unresolved", then we should ignore this component and not report
@@ -167,7 +185,9 @@ module.exports = {
           }
           return component.declaredPropTypes !== undefined;
         }).forEach((component) => {
-          if (forceDefaultPropArguments && astUtil.isFunctionLike(component.node)) {
+          if (functions === 'defaultArguments'
+              && astUtil.isFunctionLike(component.node)
+          ) {
             reportFunctionComponent(
               component.node,
               component.declaredPropTypes,

tests/lib/rules/require-default-props.js

@@ -235,7 +235,7 @@ ruleTester.run('require-default-props', rule, {
           bar: PropTypes.string.isRequired
         };
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
     {
       code: `
@@ -247,7 +247,7 @@ ruleTester.run('require-default-props', rule, {
           bar: PropTypes.string
         };
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
     {
       code: `
@@ -259,7 +259,7 @@ ruleTester.run('require-default-props', rule, {
           bar: PropTypes.string.isRequired,
         };
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
     {
       code: `
@@ -273,7 +273,7 @@ ruleTester.run('require-default-props', rule, {
           world: PropTypes.string.isRequired
         }
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
     {
       code: `
@@ -287,7 +287,7 @@ ruleTester.run('require-default-props', rule, {
           world: PropTypes.string.isRequired
         }
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
 
     // stateless components as function expressions
@@ -335,7 +335,7 @@ ruleTester.run('require-default-props', rule, {
           bar: PropTypes.string
         };
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
 
     // stateless components as arrow function expressions
@@ -385,7 +385,7 @@ ruleTester.run('require-default-props', rule, {
           bar: PropTypes.string
         };
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
 
     // createReactClass components
@@ -486,7 +486,7 @@ ruleTester.run('require-default-props', rule, {
           }
         });
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
 
     // ES6 class component
@@ -623,7 +623,7 @@ ruleTester.run('require-default-props', rule, {
           foo: "foo"
         };
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
 
     // edge cases
@@ -775,7 +775,7 @@ ruleTester.run('require-default-props', rule, {
           return <div>{foo}{bar}</div>;
         }
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
     {
       code: `
@@ -1116,7 +1116,7 @@ ruleTester.run('require-default-props', rule, {
         }
       `,
       features: ['types'],
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
     {
       code: `
@@ -1129,7 +1129,7 @@ ruleTester.run('require-default-props', rule, {
         }
       `,
       features: ['types'],
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
     {
       code: `
@@ -1172,7 +1172,7 @@ ruleTester.run('require-default-props', rule, {
         }
       `,
       features: ['ts'],
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
     },
   ]),
 
@@ -1346,7 +1346,7 @@ ruleTester.run('require-default-props', rule, {
         }
         MyStatelessComponent.propTypes = types;
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
       errors: [
         {
           messageId: 'shouldAssignObjectDefault',
@@ -1365,7 +1365,7 @@ ruleTester.run('require-default-props', rule, {
         }
         MyStatelessComponent.propTypes = types;
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
       errors: [
         {
           messageId: 'destructureInSignature',
@@ -1386,7 +1386,7 @@ ruleTester.run('require-default-props', rule, {
           world: PropTypes.string.isRequired
         }
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
       errors: [
         {
           messageId: 'shouldAssignObjectDefault',
@@ -2704,7 +2704,7 @@ ruleTester.run('require-default-props', rule, {
           foo: 'bar'
         };
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
       errors: [
         {
           messageId: 'noDefaultPropsWithFunction',
@@ -2721,7 +2721,7 @@ ruleTester.run('require-default-props', rule, {
           bar: PropTypes.string
         };
       `,
-      options: [{ forceDefaultPropArguments: true }],
+      options: [{ functions: 'defaultArguments' }],
       errors: [
         {
           messageId: 'destructureInSignature',