Skip to content

Commit 849ae12

Browse files
committed
Simplify auto-globals checks
1 parent fba8b95 commit 849ae12

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

ext/opcache/ZendAccelerator.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1675,7 +1675,7 @@ static void zend_accel_set_auto_globals(int mask)
16751675
int n = 1;
16761676

16771677
for (i = 0; i < ag_size ; i++) {
1678-
if ((mask & n) && !(ZCG(auto_globals_mask) & n)) {
1678+
if (mask & n) {
16791679
ZCG(auto_globals_mask) |= n;
16801680
zend_is_auto_global(jit_auto_globals_str[i]);
16811681
}
@@ -1948,8 +1948,8 @@ zend_op_array *file_cache_compile_file(zend_file_handle *file_handle, int type)
19481948
}
19491949
replay_warnings(persistent_script);
19501950

1951-
if (persistent_script->ping_auto_globals_mask) {
1952-
zend_accel_set_auto_globals(persistent_script->ping_auto_globals_mask);
1951+
if (persistent_script->ping_auto_globals_mask & ~ZCG(auto_globals_mask)) {
1952+
zend_accel_set_auto_globals(persistent_script->ping_auto_globals_mask & ~ZCG(auto_globals_mask));
19531953
}
19541954

19551955
return zend_accel_load_script(persistent_script, 1);
@@ -2273,8 +2273,8 @@ zend_op_array *persistent_compile_file(zend_file_handle *file_handle, int type)
22732273
HANDLE_UNBLOCK_INTERRUPTIONS();
22742274

22752275
/* Fetch jit auto globals used in the script before execution */
2276-
if (persistent_script->ping_auto_globals_mask) {
2277-
zend_accel_set_auto_globals(persistent_script->ping_auto_globals_mask);
2276+
if (persistent_script->ping_auto_globals_mask & ~ZCG(auto_globals_mask)) {
2277+
zend_accel_set_auto_globals(persistent_script->ping_auto_globals_mask & ~ZCG(auto_globals_mask));
22782278
}
22792279

22802280
return zend_accel_load_script(persistent_script, from_shared_memory);
@@ -3538,8 +3538,8 @@ static void preload_shutdown(void)
35383538

35393539
static void preload_activate(void)
35403540
{
3541-
if (ZCSG(preload_script)->ping_auto_globals_mask) {
3542-
zend_accel_set_auto_globals(ZCSG(preload_script)->ping_auto_globals_mask);
3541+
if (ZCSG(preload_script)->ping_auto_globals_mask & ~ZCG(auto_globals_mask)) {
3542+
zend_accel_set_auto_globals(ZCSG(preload_script)->ping_auto_globals_mask & ~ZCG(auto_globals_mask));
35433543
}
35443544
}
35453545

@@ -4564,8 +4564,8 @@ static zend_result preload_autoload(zend_string *filename)
45644564

45654565
zend_hash_add_empty_element(&EG(included_files), filename);
45664566

4567-
if (persistent_script->ping_auto_globals_mask) {
4568-
zend_accel_set_auto_globals(persistent_script->ping_auto_globals_mask);
4567+
if (persistent_script->ping_auto_globals_mask & ~ZCG(auto_globals_mask)) {
4568+
zend_accel_set_auto_globals(persistent_script->ping_auto_globals_mask & ~ZCG(auto_globals_mask));
45694569
}
45704570

45714571
op_array = zend_accel_load_script(persistent_script, 1);

0 commit comments

Comments
 (0)