Flesh out some more ignore cases for object validators.

Julian · Julian · commit c47341a91e90 · 2017-06-18T10:22:32.000-04:00
Some languages have sequence types covering hash maps,
arrays, and strings. Make sure those languages properly
notice to ignore these validators on non-objects.
diff --git a/tests/draft3/additionalProperties.json b/tests/draft3/additionalProperties.json
@@ -19,10 +19,20 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
                 "data": [1, 2, 3],
                 "valid": true
             },
+            {
+                "description": "ignores strings",
+                "data": "foobarbaz",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
+            },
             {
                 "description": "patternProperties are not additional properties",
                 "data": {"foo":1, "vroom": 2},
diff --git a/tests/draft3/dependencies.json b/tests/draft3/dependencies.json
@@ -26,8 +26,18 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
-                "data": "foo",
+                "description": "ignores arrays",
+                "data": ["bar"],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
+                "data": "foobar",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
                 "valid": true
             }
         ]
diff --git a/tests/draft3/patternProperties.json b/tests/draft3/patternProperties.json
@@ -29,7 +29,12 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": [],
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
                 "data": 12,
                 "valid": true
             }
diff --git a/tests/draft3/properties.json b/tests/draft3/properties.json
@@ -29,9 +29,14 @@
                 "valid": true
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
                 "data": [],
                 "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
             }
         ]
     },
diff --git a/tests/draft4/additionalProperties.json b/tests/draft4/additionalProperties.json
@@ -19,10 +19,20 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
                 "data": [1, 2, 3],
                 "valid": true
             },
+            {
+                "description": "ignores strings",
+                "data": "foobarbaz",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
+            },
             {
                 "description": "patternProperties are not additional properties",
                 "data": {"foo":1, "vroom": 2},
diff --git a/tests/draft4/dependencies.json b/tests/draft4/dependencies.json
@@ -26,8 +26,18 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
-                "data": "foo",
+                "description": "ignores arrays",
+                "data": ["bar"],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
+                "data": "foobar",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
                 "valid": true
             }
         ]
diff --git a/tests/draft4/maxProperties.json b/tests/draft4/maxProperties.json
@@ -19,9 +19,19 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": [1, 2, 3],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
                 "data": "foobar",
                 "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
             }
         ]
     }
diff --git a/tests/draft4/minProperties.json b/tests/draft4/minProperties.json
@@ -19,9 +19,19 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": [],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
                 "data": "",
                 "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
             }
         ]
     }
diff --git a/tests/draft4/patternProperties.json b/tests/draft4/patternProperties.json
@@ -29,7 +29,17 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": [],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
+                "data": "",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
                 "data": 12,
                 "valid": true
             }
diff --git a/tests/draft4/properties.json b/tests/draft4/properties.json
@@ -29,9 +29,14 @@
                 "valid": true
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
                 "data": [],
                 "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
             }
         ]
     },
diff --git a/tests/draft4/required.json b/tests/draft4/required.json
@@ -20,7 +20,17 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": [],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
+                "data": "",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
                 "data": 12,
                 "valid": true
             }
diff --git a/tests/draft6/additionalProperties.json b/tests/draft6/additionalProperties.json
@@ -19,10 +19,20 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
                 "data": [1, 2, 3],
                 "valid": true
             },
+            {
+                "description": "ignores strings",
+                "data": "foobarbaz",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
+            },
             {
                 "description": "patternProperties are not additional properties",
                 "data": {"foo":1, "vroom": 2},
diff --git a/tests/draft6/dependencies.json b/tests/draft6/dependencies.json
@@ -26,8 +26,18 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
-                "data": "foo",
+                "description": "ignores arrays",
+                "data": ["bar"],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
+                "data": "foobar",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
                 "valid": true
             }
         ]
diff --git a/tests/draft6/maxProperties.json b/tests/draft6/maxProperties.json
@@ -19,9 +19,19 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": [1, 2, 3],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
                 "data": "foobar",
                 "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
             }
         ]
     }
diff --git a/tests/draft6/minProperties.json b/tests/draft6/minProperties.json
@@ -19,9 +19,19 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": [],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
                 "data": "",
                 "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
             }
         ]
     }
diff --git a/tests/draft6/patternProperties.json b/tests/draft6/patternProperties.json
@@ -29,7 +29,17 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": ["foo"],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
+                "data": "foo",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
                 "data": 12,
                 "valid": true
             }
diff --git a/tests/draft6/properties.json b/tests/draft6/properties.json
@@ -29,9 +29,14 @@
                 "valid": true
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
                 "data": [],
                 "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
+                "valid": true
             }
         ]
     },
diff --git a/tests/draft6/propertyNames.json b/tests/draft6/propertyNames.json
@@ -27,8 +27,18 @@
                 "valid": true
             },
             {
-                "description": "non-object is valid",
-                "data": [],
+                "description": "ignores arrays",
+                "data": [1, 2, 3, 4],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
+                "data": "foobar",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
+                "data": 12,
                 "valid": true
             }
         ]
diff --git a/tests/draft6/required.json b/tests/draft6/required.json
@@ -20,7 +20,17 @@
                 "valid": false
             },
             {
-                "description": "ignores non-objects",
+                "description": "ignores arrays",
+                "data": [],
+                "valid": true
+            },
+            {
+                "description": "ignores strings",
+                "data": "",
+                "valid": true
+            },
+            {
+                "description": "ignores other non-objects",
                 "data": 12,
                 "valid": true
             }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,12 @@`
`29`	`29`	`"valid": false`
`30`	`30`	`},`
`31`	`31`	`{`
`32`		`- "description": "ignores non-objects",`
	`32`	`+ "description": "ignores arrays",`
	`33`	`+ "data": [],`
	`34`	`+ "valid": true`
	`35`	`+ },`
	`36`	`+ {`
	`37`	`+ "description": "ignores other non-objects",`
`33`	`38`	`"data": 12,`
`34`	`39`	`"valid": true`
`35`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,14 @@`
`29`	`29`	`"valid": true`
`30`	`30`	`},`
`31`	`31`	`{`
`32`		`- "description": "ignores non-objects",`
	`32`	`+ "description": "ignores arrays",`
`33`	`33`	`"data": [],`
`34`	`34`	`"valid": true`
	`35`	`+ },`
	`36`	`+ {`
	`37`	`+ "description": "ignores other non-objects",`
	`38`	`+ "data": 12,`
	`39`	`+ "valid": true`
`35`	`40`	`}`
`36`	`41`	`]`
`37`	`42`	`},`
Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,19 @@`
`19`	`19`	`"valid": false`
`20`	`20`	`},`
`21`	`21`	`{`
`22`		`- "description": "ignores non-objects",`
	`22`	`+ "description": "ignores arrays",`
	`23`	`+ "data": [1, 2, 3],`
	`24`	`+ "valid": true`
	`25`	`+ },`
	`26`	`+ {`
	`27`	`+ "description": "ignores strings",`
`23`	`28`	`"data": "foobar",`
`24`	`29`	`"valid": true`
	`30`	`+ },`
	`31`	`+ {`
	`32`	`+ "description": "ignores other non-objects",`
	`33`	`+ "data": 12,`
	`34`	`+ "valid": true`
`25`	`35`	`}`
`26`	`36`	`]`
`27`	`37`	`}`