$ref wit id does not test what it is indented to do

santhosh-tekuri · jdesrosiers · commit 9103f3b6ffee · 2021-09-18T16:35:05.000-07:00
whether the implementation resolves $ref to
/definitions/foo or /definitions/base_foo
current tests will always pass
diff --git a/tests/draft3/ref.json b/tests/draft3/ref.json
@@ -207,17 +207,17 @@
             "definitions": {
                 "foo": {
                     "id": "http://localhost:1234/sibling_id/foo.json",
-                    "minimum": 2
+                    "type": "string"
                 },
                 "base_foo": {
                     "$comment": "this canonical uri is http://localhost:1234/sibling_id/base/foo.json",
                     "id": "foo.json",
-                    "minimum": 5
+                    "type": "number"
                 }
             },
             "allOf": [
                 {
-                    "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not ttp://localhost:1234/sibling_id/foo.json",
+                    "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not http://localhost:1234/sibling_id/foo.json",
                     "id": "http://localhost:1234/sibling_id/",
                     "$ref": "foo.json"
                 }
@@ -226,7 +226,7 @@
         "tests": [
             {
                 "description": "$ref resolves to /definitions/foo, data validates",
-                "data": 10,
+                "data": "a",
                 "valid": true
             },
             {
diff --git a/tests/draft4/ref.json b/tests/draft4/ref.json
@@ -182,17 +182,17 @@
             "definitions": {
                 "foo": {
                     "id": "http://localhost:1234/sibling_id/foo.json",
-                    "minimum": 2
+                    "type": "string"
                 },
                 "base_foo": {
                     "$comment": "this canonical uri is http://localhost:1234/sibling_id/base/foo.json",
                     "id": "foo.json",
-                    "minimum": 5
+                    "type": "number"
                 }
             },
             "allOf": [
                 {
-                    "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not ttp://localhost:1234/sibling_id/foo.json",
+                    "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not http://localhost:1234/sibling_id/foo.json",
                     "id": "http://localhost:1234/sibling_id/",
                     "$ref": "foo.json"
                 }
@@ -201,7 +201,7 @@
         "tests": [
             {
                 "description": "$ref resolves to /definitions/foo, data validates",
-                "data": 10,
+                "data": "a",
                 "valid": true
             },
             {
diff --git a/tests/draft6/ref.json b/tests/draft6/ref.json
@@ -182,17 +182,17 @@
             "definitions": {
                 "foo": {
                     "$id": "http://localhost:1234/sibling_id/foo.json",
-                    "minimum": 2
+                    "type": "string"
                 },
                 "base_foo": {
                     "$comment": "this canonical uri is http://localhost:1234/sibling_id/base/foo.json",
                     "$id": "foo.json",
-                    "minimum": 5
+                    "type": "number"
                 }
             },
             "allOf": [
                 {
-                    "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not ttp://localhost:1234/sibling_id/foo.json",
+                    "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not http://localhost:1234/sibling_id/foo.json",
                     "$id": "http://localhost:1234/sibling_id/",
                     "$ref": "foo.json"
                 }
@@ -201,7 +201,7 @@
         "tests": [
             {
                 "description": "$ref resolves to /definitions/foo, data validates",
-                "data": 10,
+                "data": "a",
                 "valid": true
             },
             {
diff --git a/tests/draft7/ref.json b/tests/draft7/ref.json
@@ -182,17 +182,17 @@
             "definitions": {
                 "foo": {
                     "$id": "http://localhost:1234/sibling_id/foo.json",
-                    "minimum": 2
+                    "type": "string"
                 },
                 "base_foo": {
                     "$comment": "this canonical uri is http://localhost:1234/sibling_id/base/foo.json",
                     "$id": "foo.json",
-                    "minimum": 5
+                    "type": "number"
                 }
             },
             "allOf": [
                 {
-                    "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not ttp://localhost:1234/sibling_id/foo.json",
+                    "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not http://localhost:1234/sibling_id/foo.json",
                     "$id": "http://localhost:1234/sibling_id/",
                     "$ref": "foo.json"
                 }
@@ -201,7 +201,7 @@
         "tests": [
             {
                 "description": "$ref resolves to /definitions/foo, data validates",
-                "data": 10,
+                "data": "a",
                 "valid": true
             },
             {

Original file line number	Diff line number	Diff line change
`@@ -207,17 +207,17 @@`
`207`	`207`	`"definitions": {`
`208`	`208`	`"foo": {`
`209`	`209`	`"id": "http://localhost:1234/sibling_id/foo.json",`
`210`		`- "minimum": 2`
	`210`	`+ "type": "string"`
`211`	`211`	`},`
`212`	`212`	`"base_foo": {`
`213`	`213`	`"$comment": "this canonical uri is http://localhost:1234/sibling_id/base/foo.json",`
`214`	`214`	`"id": "foo.json",`
`215`		`- "minimum": 5`
	`215`	`+ "type": "number"`
`216`	`216`	`}`
`217`	`217`	`},`
`218`	`218`	`"allOf": [`
`219`	`219`	`{`
`220`		`- "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not ttp://localhost:1234/sibling_id/foo.json",`
	`220`	`+ "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not http://localhost:1234/sibling_id/foo.json",`
`221`	`221`	`"id": "http://localhost:1234/sibling_id/",`
`222`	`222`	`"$ref": "foo.json"`
`223`	`223`	`}`
`@@ -226,7 +226,7 @@`
`226`	`226`	`"tests": [`
`227`	`227`	`{`
`228`	`228`	`"description": "$ref resolves to /definitions/foo, data validates",`
`229`		`- "data": 10,`
	`229`	`+ "data": "a",`
`230`	`230`	`"valid": true`
`231`	`231`	`},`
`232`	`232`	`{`
Original file line number	Diff line number	Diff line change
`@@ -182,17 +182,17 @@`
`182`	`182`	`"definitions": {`
`183`	`183`	`"foo": {`
`184`	`184`	`"id": "http://localhost:1234/sibling_id/foo.json",`
`185`		`- "minimum": 2`
	`185`	`+ "type": "string"`
`186`	`186`	`},`
`187`	`187`	`"base_foo": {`
`188`	`188`	`"$comment": "this canonical uri is http://localhost:1234/sibling_id/base/foo.json",`
`189`	`189`	`"id": "foo.json",`
`190`		`- "minimum": 5`
	`190`	`+ "type": "number"`
`191`	`191`	`}`
`192`	`192`	`},`
`193`	`193`	`"allOf": [`
`194`	`194`	`{`
`195`		`- "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not ttp://localhost:1234/sibling_id/foo.json",`
	`195`	`+ "$comment": "$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not http://localhost:1234/sibling_id/foo.json",`
`196`	`196`	`"id": "http://localhost:1234/sibling_id/",`
`197`	`197`	`"$ref": "foo.json"`
`198`	`198`	`}`
`@@ -201,7 +201,7 @@`
`201`	`201`	`"tests": [`
`202`	`202`	`{`
`203`	`203`	`"description": "$ref resolves to /definitions/foo, data validates",`
`204`		`- "data": 10,`
	`204`	`+ "data": "a",`
`205`	`205`	`"valid": true`
`206`	`206`	`},`
`207`	`207`	`{`