Merge pull request #305 from Quasilyte/quasilyte/assignOp

taowen · web-flow · commit 6dfc0bf2dd8c · 2018-09-14T09:48:25.000+08:00
simplify `x = x &lt;op&gt; y` to `x &lt;op&gt;= y`
diff --git a/extra/binary_as_string_codec.go b/extra/binary_as_string_codec.go
@@ -153,7 +153,7 @@ func (codec *binaryAsStringCodec) Decode(ptr unsafe.Pointer, iter *jsoniter.Iter
 			}
 			b4 := rawBytes[i+3]
 			b5 := rawBytes[i+4]
-			i = i + 4
+			i += 4
 			b = readHex(iter, b4, b5)
 		}
 		bytes = append(bytes, b)
@@ -178,7 +178,7 @@ func readHex(iter *jsoniter.Iterator, b1, b2 byte) byte {
 		iter.ReportError("read hex", "expects 0~9 or a~f, but found "+string([]byte{b1}))
 		return 0
 	}
-	ret = ret * 16
+	ret *= 16
 	if b2 >= '0' && b2 <= '9' {
 		ret = b2 - '0'
 	} else if b2 >= 'a' && b2 <= 'f' {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ func (codec binaryAsStringCodec) Decode(ptr unsafe.Pointer, iter jsoniter.Iter`
`153`	`153`	`}`
`154`	`154`	`b4 := rawBytes[i+3]`
`155`	`155`	`b5 := rawBytes[i+4]`
`156`		`- i = i + 4`
	`156`	`+ i += 4`
`157`	`157`	`b = readHex(iter, b4, b5)`
`158`	`158`	`}`
`159`	`159`	`bytes = append(bytes, b)`
`@@ -178,7 +178,7 @@ func readHex(iter *jsoniter.Iterator, b1, b2 byte) byte {`
`178`	`178`	`iter.ReportError("read hex", "expects 0~9 or a~f, but found "+string([]byte{b1}))`
`179`	`179`	`return 0`
`180`	`180`	`}`
`181`		`- ret = ret * 16`
	`181`	`+ ret *= 16`
`182`	`182`	`if b2 >= '0' && b2 <= '9' {`
`183`	`183`	`ret = b2 - '0'`
`184`	`184`	`} else if b2 >= 'a' && b2 <= 'f' {`