From 51b129f4643e76349273f86d6dda82299d45c8c2 Mon Sep 17 00:00:00 2001 From: "F. DeWayne Lane" Date: Sat, 28 Nov 2020 09:57:04 -0500 Subject: [PATCH 1/2] docs: update simple sample for repositoryAccessor --- docs/usage/extensibility/services.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/usage/extensibility/services.md b/docs/usage/extensibility/services.md index 2c3b612e74..629547a284 100644 --- a/docs/usage/extensibility/services.md +++ b/docs/usage/extensibility/services.md @@ -16,7 +16,7 @@ public class TodoItemService : JsonApiResourceService private readonly INotificationService _notificationService; public TodoItemService( - IResourceRepository repository, + IResourceRepositoryAccessor repositoryAccessor, IQueryLayerComposer queryLayerComposer, IPaginationContext paginationContext, IJsonApiOptions options, @@ -24,17 +24,17 @@ public class TodoItemService : JsonApiResourceService IJsonApiRequest request, IResourceChangeTracker resourceChangeTracker, IResourceFactory resourceFactory, - IResourceHookExecutor hookExecutor = null) - : base(repository, queryLayerComposer, paginationContext, options, loggerFactory, + IResourceHookExecutorFacade hookExecutor) + : base(repositoryAccessor, queryLayerComposer, paginationContext, options, loggerFactory, request, resourceChangeTracker, resourceFactory, hookExecutor) { _notificationService = notificationService; } - public override async Task CreateAsync(TodoItem resource) + public override async Task CreateAsync(TodoItem resource, CancellationToken cancellationToken) { // Call the base implementation - var newResource = await base.CreateAsync(resource); + var newResource = await base.CreateAsync(resource, cancellationToken); // Custom code _notificationService.Notify($"Resource created: {newResource.StringId}"); From ca5cca8f915cd913cc9972d3be30e819cda1b720 Mon Sep 17 00:00:00 2001 From: Bart Koelman Date: Mon, 30 Nov 2020 09:29:27 +0100 Subject: [PATCH 2/2] Updated additional places in docs for CancellationToken usage --- docs/usage/extensibility/controllers.md | 12 ++++++------ docs/usage/extensibility/repositories.md | 5 +++-- docs/usage/extensibility/services.md | 14 +++++++------- 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/docs/usage/extensibility/controllers.md b/docs/usage/extensibility/controllers.md index 1252b1c84e..125c6a23a1 100644 --- a/docs/usage/extensibility/controllers.md +++ b/docs/usage/extensibility/controllers.md @@ -51,15 +51,15 @@ public class ArticlesController : BaseJsonApiController
{ } [HttpGet] - public override async Task GetAsync() + public override async Task GetAsync(CancellationToken cancellationToken) { - return await base.GetAsync(); + return await base.GetAsync(cancellationToken); } [HttpGet("{id}")] - public override async Task GetAsync(int id) + public override async Task GetAsync(int id, CancellationToken cancellationToken) { - return await base.GetAsync(id); + return await base.GetAsync(id, cancellationToken); } } ``` @@ -108,9 +108,9 @@ public class ReportsController : BaseJsonApiController { } [HttpGet] - public override async Task GetAsync() + public override async Task GetAsync(CancellationToken cancellationToken) { - return await base.GetAsync(); + return await base.GetAsync(cancellationToken); } } ``` diff --git a/docs/usage/extensibility/repositories.md b/docs/usage/extensibility/repositories.md index 0f953d06a4..ac9a447389 100644 --- a/docs/usage/extensibility/repositories.md +++ b/docs/usage/extensibility/repositories.md @@ -51,9 +51,10 @@ public class ArticleRepository : EntityFrameworkCoreRepository
_authenticationService = authenticationService; } - public override IQueryable
GetAll() + public override IQueryable
GetAll(CancellationToken cancellationToken) { - return base.Get().Where(article => article.UserId == _authenticationService.UserId); + return base.GetAll(cancellationToken) + .Where(article => article.UserId == _authenticationService.UserId); } } ``` diff --git a/docs/usage/extensibility/services.md b/docs/usage/extensibility/services.md index 629547a284..d536e13bb4 100644 --- a/docs/usage/extensibility/services.md +++ b/docs/usage/extensibility/services.md @@ -37,7 +37,7 @@ public class TodoItemService : JsonApiResourceService var newResource = await base.CreateAsync(resource, cancellationToken); // Custom code - _notificationService.Notify($"Resource created: {newResource.StringId}"); + await _notificationService.NotifyAsync($"Resource created: {newResource.StringId}"); return newResource; } @@ -70,9 +70,9 @@ public class ProductService : IResourceService _dao = dao; } - public Task> GetAsync() + public async Task> GetAsync(CancellationToken cancellationToken) { - return await _dao.GetProductsAsync(); + return await _dao.GetProductsAsync(cancellationToken); } } ``` @@ -162,15 +162,15 @@ public class ArticlesController : BaseJsonApiController
{ } [HttpPost] - public override async Task PostAsync([FromBody] Article resource) + public override async Task PostAsync([FromBody] Article resource, CancellationToken cancellationToken) { - return await base.PostAsync(resource); + return await base.PostAsync(resource, cancellationToken); } [HttpDelete("{id}")] - public override async TaskDeleteAsync(int id) + public override async TaskDeleteAsync(int id, CancellationToken cancellationToken) { - return await base.DeleteAsync(id); + return await base.DeleteAsync(id, cancellationToken); } } ```