Merge branch 'openapi' into openapi-required-and-nullable-properties

Author: bkoelman

.config/dotnet-tools.json

@@ -21,7 +21,7 @@
       ]
     },
     "docfx": {
-      "version": "2.70.4",
+      "version": "2.71.0",
       "commands": [
         "docfx"
       ]

run-docker-postgres.ps1

@@ -1,12 +1,18 @@
 #Requires -Version 7.0
 
-# This script starts a docker container with postgres database, used for running tests.
+# This script starts a PostgreSQL database in a docker container, which is required for running tests locally.
+# When the -UI switch is passed, pgAdmin (a web-based PostgreSQL management tool) is started in a second container, which lets you query the database.
+# To connect to pgAdmin, open http://localhost:5050 and login with user "admin@admin.com", password "postgres". Use hostname "db" when registering the server.
 
-docker container stop jsonapi-dotnet-core-testing
+param(
+    [switch] $UI=$False
+)
 
-docker run --rm --name jsonapi-dotnet-core-testing       `
- -e POSTGRES_DB=JsonApiDotNetCoreExample                 `
- -e POSTGRES_USER=postgres                               `
- -e POSTGRES_PASSWORD=postgres                           `
- -p 5432:5432                                            `
- postgres:15
+docker container stop jsonapi-postgresql-db
+docker container stop jsonapi-postgresql-management
+
+docker run --pull always --rm --detach --name jsonapi-postgresql-db -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD=postgres -p 5432:5432 postgres:latest
+
+if ($UI) {
+    docker run --pull always --rm --detach --name jsonapi-postgresql-management --link jsonapi-postgresql-db:db -e PGADMIN_DEFAULT_EMAIL=admin@admin.com -e PGADMIN_DEFAULT_PASSWORD=postgres -p 5050:80 dpage/pgadmin4:latest
+}

src/JsonApiDotNetCore.SourceGenerators/ControllerSourceGenerator.cs

@@ -6,8 +6,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Text;
 
-#pragma warning disable RS2008 // Enable analyzer release tracking
-
 namespace JsonApiDotNetCore.SourceGenerators;
 // To debug in Visual Studio (requires v17.2 or higher):
 // - Set JsonApiDotNetCore.SourceGenerators as startup project

test/JsonApiDotNetCoreTests/UnitTests/Links/LinkInclusionTests.cs

@@ -403,7 +403,6 @@ public ResourceType GetResourceTypeForController(Type? controllerType)
 
     private sealed class FakeLinkGenerator : LinkGenerator
     {
-#pragma warning disable AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
         public override string GetPathByAddress<TAddress>(HttpContext httpContext, TAddress address, RouteValueDictionary values,
             RouteValueDictionary? ambientValues = null, PathString? pathBase = null, FragmentString fragment = new(), LinkOptions? options = null)
         {
@@ -428,6 +427,5 @@ public override string GetUriByAddress<TAddress>(TAddress address, RouteValueDic
         {
             throw new NotImplementedException();
         }
-#pragma warning restore AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
     }
 }