review feedback

Author: maurei

JsonApiDotNetCore.sln

@@ -44,7 +44,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MultiDbContextTests", "test
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestBuildingBlocks", "test\TestBuildingBlocks\TestBuildingBlocks.csproj", "{210FD61E-FF5D-4CEE-8E0D-C739ECCCBA21}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "OpenApi", "src\OpenApi\OpenApi.csproj", "{71287D6F-6C3B-44B4-9FCA-E78FE3F02289}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "JsonApiDotNetCore.OpenApi", "src\JsonApiDotNetCore.OpenApi\JsonApiDotNetCore.OpenApi.csproj", "{71287D6F-6C3B-44B4-9FCA-E78FE3F02289}"
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "OpenApiTests", "test\OpenApiTests\OpenApiTests.csproj", "{B693DE14-BB28-496F-AB39-B4E674ABCA80}"
 EndProject

appveyor.yml

@@ -36,13 +36,13 @@ for:
     - image: Visual Studio 2019
   services:
   - postgresql101
-  # REF: https://github.com/docascode/docfx-seed/blob/master/appveyor.yml
+  # This ensures the base branch is loaded which is required for regitlint to run.
   clone_script:
-    # This ensures the base branch is loaded which is required for regitlint to run.
     - ps: |
         git clone --branch=$env:APPVEYOR_REPO_BRANCH git@github.com:$env:APPVEYOR_REPO_NAME.git $env:APPVEYOR_BUILD_FOLDER
         git fetch -q origin +refs/pull/$env:APPVEYOR_PULL_REQUEST_NUMBER/merge:
         git checkout -qf FETCH_HEAD
+  # REF: https://github.com/docascode/docfx-seed/blob/master/appveyor.yml
   before_build:
     - pwsh: |
         if (-Not $env:APPVEYOR_PULL_REQUEST_TITLE) {

src/OpenApi/OpenApi.csproj renamed to src/JsonApiDotNetCore.OpenApi/JsonApiDotNetCore.OpenApi.csproj

@@ -4,7 +4,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="Swashbuckle.AspNetCore" Version="$(SwashbuckleVersion)"/>
+      <PackageReference Include="Swashbuckle.AspNetCore" Version="$(SwashbuckleVersion)" />
       <PackageReference Include="Swashbuckle.AspNetCore.Annotations" Version="$(SwashbuckleVersion)" />
       <PackageReference Include="Swashbuckle.AspNetCore.Newtonsoft" Version="$(SwashbuckleVersion)" />
     </ItemGroup>

src/OpenApi/OpenApiEndpointConvention.cs renamed to src/JsonApiDotNetCore.OpenApi/OpenApiEndpointConvention.cs

@@ -1,9 +1,8 @@
 using System.Linq;
-using JsonApiDotNetCore;
 using Microsoft.AspNetCore.Mvc.ApplicationModels;
 using Microsoft.AspNetCore.Mvc.Routing;
 
-namespace OpenApi
+namespace JsonApiDotNetCore.OpenApi
 {
     internal sealed class OpenApiEndpointConvention : IActionModelConvention
     {

src/OpenApi/ServiceCollectionExtensions.cs renamed to src/JsonApiDotNetCore.OpenApi/ServiceCollectionExtensions.cs

@@ -1,9 +1,8 @@
 using System;
-using JsonApiDotNetCore;
 using Microsoft.Extensions.DependencyInjection;
 using Swashbuckle.AspNetCore.SwaggerGen;
 
-namespace OpenApi
+namespace JsonApiDotNetCore.OpenApi
 {
     public static class ServiceCollectionExtensions
     {

src/JsonApiDotNetCore/Properties/AssemblyInfo.cs

@@ -1,6 +1,6 @@
 using System.Runtime.CompilerServices;
 
-[assembly: InternalsVisibleTo("OpenApi")]
+[assembly: InternalsVisibleTo("JsonApiDotNetCore.OpenApi")]
 [assembly: InternalsVisibleTo("Benchmarks")]
 [assembly: InternalsVisibleTo("JsonApiDotNetCoreTests")]
 [assembly: InternalsVisibleTo("UnitTests")]

test/OpenApiTests/Airplane.cs

@@ -7,7 +7,7 @@
 namespace OpenApiTests
 {
     [UsedImplicitly(ImplicitUseTargetFlags.Members)]
-    public sealed class Airplane : Identifiable<int>
+    public sealed class Airplane : Identifiable
     {
         [Attr]
         public int SeatingCapacity { get; set; }

test/OpenApiTests/AirplanesController.cs

@@ -5,7 +5,7 @@
 
 namespace OpenApiTests
 {
-    public sealed class AirplanesController : JsonApiController<Airplane, int>
+    public sealed class AirplanesController : JsonApiController<Airplane>
     {
         public AirplanesController(IJsonApiOptions options, ILoggerFactory loggerFactory, IResourceService<Airplane, int> resourceService)
             : base(options, loggerFactory, resourceService)

test/OpenApiTests/Flight.cs

@@ -6,12 +6,12 @@
 namespace OpenApiTests
 {
     [UsedImplicitly(ImplicitUseTargetFlags.Members)]
-    public sealed class Flight : Identifiable<int>
+    public sealed class Flight : Identifiable
     {
         [Attr]
         public string Destination { get; set; }
 
         [Attr]
-        public DateTimeOffset PlannedDeparture { get; set; }
+        public DateTimeOffset DepartsAt { get; set; }
     }
 }

test/OpenApiTests/FlightsController.cs

@@ -5,9 +5,9 @@
 
 namespace OpenApiTests
 {
-    public sealed class FlightsController : JsonApiController<Flight, int>
+    public sealed class FlightsController : JsonApiController<Flight>
     {
-        public FlightsController(IJsonApiOptions options, ILoggerFactory loggerFactory, IResourceService<Flight, int> resourceService)
+        public FlightsController(IJsonApiOptions options, ILoggerFactory loggerFactory, IResourceService<Flight> resourceService)
             : base(options, loggerFactory, resourceService)
         {
         }

test/OpenApiTests/OpenApiStartup.cs

@@ -1,11 +1,11 @@
 using JsonApiDotNetCore.Configuration;
+using JsonApiDotNetCore.OpenApi;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.OpenApi.Models;
-using OpenApi;
 using TestBuildingBlocks;
 
 namespace OpenApiTests

test/OpenApiTests/OpenApiTests.csproj

@@ -11,7 +11,7 @@
 
     <ItemGroup>
         <ProjectReference Include="..\..\src\Examples\JsonApiDotNetCoreExample\JsonApiDotNetCoreExample.csproj" />
-        <ProjectReference Include="..\..\src\OpenApi\OpenApi.csproj" />
+        <ProjectReference Include="..\..\src\JsonApiDotNetCore.OpenApi\JsonApiDotNetCore.OpenApi.csproj" />
         <ProjectReference Include="..\TestBuildingBlocks\TestBuildingBlocks.csproj" />
     </ItemGroup>