Fix CA1854: Prefer the IDictionary.TryGetValue(TKey, out TValue) method

bkoelman · bkoelman · commit ef56e34b863c · 2024-10-01T12:20:31.000+02:00
diff --git a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/JsonApiClient.cs b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/JsonApiClient.cs
@@ -137,12 +137,13 @@ public void RegisterDocument(object document, AlwaysIncludedAttributes alwaysInc
 
             Type documentType = document.GetType();
 
-            if (!_documentsByType.ContainsKey(documentType))
+            if (!_documentsByType.TryGetValue(documentType, out ISet<object>? documents))
             {
-                _documentsByType[documentType] = new HashSet<object>();
+                documents = new HashSet<object>();
+                _documentsByType[documentType] = documents;
             }
 
-            _documentsByType[documentType].Add(document);
+            documents.Add(document);
         }
 
         public void UnRegisterDocument(object document)

Original file line number	Diff line number	Diff line change
`@@ -137,12 +137,13 @@ public void RegisterDocument(object document, AlwaysIncludedAttributes alwaysInc`
`137`	`137`
`138`	`138`	`Type documentType = document.GetType();`
`139`	`139`
`140`		`- if (!_documentsByType.ContainsKey(documentType))`
	`140`	`+ if (!_documentsByType.TryGetValue(documentType, out ISet<object>? documents))`
`141`	`141`	`{`
`142`		`- _documentsByType[documentType] = new HashSet<object>();`
	`142`	`+ documents = new HashSet<object>();`
	`143`	`+ _documentsByType[documentType] = documents;`
`143`	`144`	`}`
`144`	`145`
`145`		`- _documentsByType[documentType].Add(document);`
	`146`	`+ documents.Add(document);`
`146`	`147`	`}`
`147`	`148`
`148`	`149`	`public void UnRegisterDocument(object document)`