Skip to content

Commit dc0c75a

Browse files
committed
fix: review
1 parent 787002a commit dc0c75a

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

src/JsonApiDotNetCore/Builders/IResourceGraphBuilder.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,30 +15,30 @@ public interface IResourceGraphBuilder
1515
/// Add a json:api resource
1616
/// </summary>
1717
/// <typeparam name="TResource">The resource model type</typeparam>
18-
/// <param name="pluralizedResourceName">
18+
/// <param name="publicResourceName">
1919
/// The pluralized name that should be exposed by the API.
2020
/// If nothing is specified, the configured name formatter will be used.
2121
/// </param>
22-
IResourceGraphBuilder AddResource<TResource>(string pluralizedResourceName = null) where TResource : class, IIdentifiable<int>;
22+
IResourceGraphBuilder AddResource<TResource>(string publicResourceName = null) where TResource : class, IIdentifiable<int>;
2323
/// <summary>
2424
/// Add a json:api resource
2525
/// </summary>
2626
/// <typeparam name="TResource">The resource model type</typeparam>
2727
/// <typeparam name="TId">The resource model identifier type</typeparam>
28-
/// <param name="pluralizedResourceName">
28+
/// <param name="publicResourceName">
2929
/// The pluralized name that should be exposed by the API.
3030
/// If nothing is specified, the configured name formatter will be used.
3131
/// </param>
32-
IResourceGraphBuilder AddResource<TResource, TId>(string pluralizedResourceName = null) where TResource : class, IIdentifiable<TId>;
32+
IResourceGraphBuilder AddResource<TResource, TId>(string publicResourceName = null) where TResource : class, IIdentifiable<TId>;
3333
/// <summary>
3434
/// Add a Json:Api resource
3535
/// </summary>
3636
/// <param name="resourceType">The resource model type</param>
3737
/// <param name="idType">The resource model identifier type</param>
38-
/// <param name="pluralizedResourceName">
38+
/// <param name="publicResourceName">
3939
/// The pluralized name that should be exposed by the API.
4040
/// If nothing is specified, the configured name formatter will be used.
4141
/// </param>
42-
IResourceGraphBuilder AddResource(Type resourceType, Type idType = null, string pluralizedResourceName = null);
42+
IResourceGraphBuilder AddResource(Type resourceType, Type idType = null, string publicResourceName = null);
4343
}
4444
}

src/JsonApiDotNetCore/Builders/ResourceGraphBuilder.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,23 +44,23 @@ private void SetResourceLinksOptions(ResourceContext resourceContext)
4444
}
4545

4646
/// <inheritdoc />
47-
public IResourceGraphBuilder AddResource<TResource>(string pluralizedResourceName = null) where TResource : class, IIdentifiable<int>
48-
=> AddResource<TResource, int>(pluralizedResourceName);
47+
public IResourceGraphBuilder AddResource<TResource>(string publicResourceName = null) where TResource : class, IIdentifiable<int>
48+
=> AddResource<TResource, int>(publicResourceName);
4949

5050
/// <inheritdoc />
51-
public IResourceGraphBuilder AddResource<TResource, TId>(string pluralizedResourceName = null) where TResource : class, IIdentifiable<TId>
52-
=> AddResource(typeof(TResource), typeof(TId), pluralizedResourceName);
51+
public IResourceGraphBuilder AddResource<TResource, TId>(string publicResourceName = null) where TResource : class, IIdentifiable<TId>
52+
=> AddResource(typeof(TResource), typeof(TId), publicResourceName);
5353

5454
/// <inheritdoc />
55-
public IResourceGraphBuilder AddResource(Type resourceType, Type idType = null, string pluralizedResourceName = null)
55+
public IResourceGraphBuilder AddResource(Type resourceType, Type idType = null, string publicResourceName = null)
5656
{
5757
if (_resources.All(e => e.ResourceType != resourceType))
5858
{
5959
if (resourceType.IsOrImplementsInterface(typeof(IIdentifiable)))
6060
{
61-
pluralizedResourceName ??= FormatResourceName(resourceType);
61+
publicResourceName ??= FormatResourceName(resourceType);
6262
idType ??= TypeLocator.GetIdType(resourceType);
63-
var resourceContext = CreateResourceContext(pluralizedResourceName, resourceType, idType);
63+
var resourceContext = CreateResourceContext(publicResourceName, resourceType, idType);
6464
_resources.Add(resourceContext);
6565
}
6666
else
@@ -72,9 +72,9 @@ public IResourceGraphBuilder AddResource(Type resourceType, Type idType = null,
7272
return this;
7373
}
7474

75-
private ResourceContext CreateResourceContext(string pluralizedResourceName, Type resourceType, Type idType) => new ResourceContext
75+
private ResourceContext CreateResourceContext(string publicResourceName, Type resourceType, Type idType) => new ResourceContext
7676
{
77-
ResourceName = pluralizedResourceName,
77+
ResourceName = publicResourceName,
7878
ResourceType = resourceType,
7979
IdentityType = idType,
8080
Attributes = GetAttributes(resourceType),

src/JsonApiDotNetCore/Models/Annotation/ResourceAttribute.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ namespace JsonApiDotNetCore.Models.Annotation
55
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Struct | AttributeTargets.Interface)]
66
public sealed class ResourceAttribute : Attribute
77
{
8-
public ResourceAttribute(string pluralizedResourceName)
8+
public ResourceAttribute(string publicResourceName)
99
{
10-
ResourceName = pluralizedResourceName;
10+
ResourceName = publicResourceName;
1111
}
1212

1313
public string ResourceName { get; }

0 commit comments

Comments
 (0)