Skip to content

Commit d42a274

Browse files
committed
Tests for leading, trailing, and spaces
1 parent ea16aaf commit d42a274

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

test/JsonApiDotNetCoreExampleTests/UnitTests/QueryStringParameters/FilterParseTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@ public void Reader_Read_Fails(string parameterName, string parameterValue, strin
115115
[InlineData("filter", "equals(title,'Brian O''Quote')", null, "equals(title,'Brian O''Quote')")]
116116
[InlineData("filter", "equals(title,'!@#$%^&*()-_=+\"''[]{}<>()/|\\:;.,`~')", null, "equals(title,'!@#$%^&*()-_=+\"''[]{}<>()/|\\:;.,`~')")]
117117
[InlineData("filter", "equals(title,'')", null, "equals(title,'')")]
118+
[InlineData("filter", "equals(title,' start with space')", null, "equals(title,' start with space')")]
119+
[InlineData("filter", "equals(title,'trailing space ')", null, "equals(title,'trailing space ')")]
118120
[InlineData("filter[posts]", "equals(caption,'this, that & more')", "posts", "equals(caption,'this, that & more')")]
119121
[InlineData("filter[owner.posts]", "equals(caption,'some')", "owner.posts", "equals(caption,'some')")]
120122
[InlineData("filter[posts.comments]", "equals(createdAt,'2000-01-01')", "posts.comments", "equals(createdAt,'2000-01-01')")]

test/JsonApiDotNetCoreExampleTests/UnitTests/QueryStringParameters/LegacyFilterParseTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ public LegacyFilterParseTests()
3737
[InlineData("filter[author]", "some", "Attribute 'author' does not exist on resource 'blogPosts'.")]
3838
[InlineData("filter[author.posts]", "some", "Field 'posts' in 'author.posts' must be an attribute or a to-one relationship on resource 'webAccounts'.")]
3939
[InlineData("filter[unknown.id]", "some", "Relationship 'unknown' in 'unknown.id' does not exist on resource 'blogPosts'.")]
40-
[InlineData("filter[author]", " ", "Unexpected whitespace.")]
4140
[InlineData("filter", "expr:equals(some,'other')", "Field 'some' does not exist on resource 'blogPosts'.")]
4241
[InlineData("filter", "expr:equals(author,'Joe')", "Attribute 'author' does not exist on resource 'blogPosts'.")]
4342
[InlineData("filter", "expr:has(author)", "Relationship 'author' must be a to-many relationship on resource 'blogPosts'.")]
@@ -77,6 +76,7 @@ public void Reader_Read_Fails(string parameterName, string parameterValue, strin
7776
[InlineData("filter[caption]", "unknown:some", "equals(caption,'unknown:some')")]
7877
[InlineData("filter[author.userName]", "Jack", "equals(author.userName,'Jack')")]
7978
[InlineData("filter", "expr:equals(caption,'some')", "equals(caption,'some')")]
79+
[InlineData("filter", "expr:equals(caption,' ')", "equals(caption,' ')")]
8080
[InlineData("filter", "expr:equals(author,null)", "equals(author,null)")]
8181
[InlineData("filter", "expr:has(author.posts)", "has(author.posts)")]
8282
[InlineData("filter", "expr:equals(count(author.posts),'1')", "equals(count(author.posts),'1')")]

0 commit comments

Comments
 (0)