Process feedback

Author: maurei

src/JsonApiDotNetCore.OpenApi.Client/ApiException.cs

@@ -22,9 +22,4 @@ public ApiException(string message, int statusCode, string? response, IReadOnlyD
         Response = response;
         Headers = headers;
     }
-
-    public override string ToString()
-    {
-        return $"HTTP Response: \n\n{Response}\n\n{base.ToString()}";
-    }
 }

test/OpenApiTests/NamingConventions/CamelCase/CamelCaseTests.cs

@@ -4,12 +4,12 @@
 
 namespace OpenApiTests.NamingConventions.CamelCase;
 
-public sealed class PascalCaseTests
+public sealed class CamelCaseTests
     : IClassFixture<OpenApiTestContext<CamelCaseNamingConventionStartup<NamingConventionsDbContext>, NamingConventionsDbContext>>
 {
     private readonly OpenApiTestContext<CamelCaseNamingConventionStartup<NamingConventionsDbContext>, NamingConventionsDbContext> _testContext;
 
-    public PascalCaseTests(OpenApiTestContext<CamelCaseNamingConventionStartup<NamingConventionsDbContext>, NamingConventionsDbContext> testContext)
+    public CamelCaseTests(OpenApiTestContext<CamelCaseNamingConventionStartup<NamingConventionsDbContext>, NamingConventionsDbContext> testContext)
     {
         _testContext = testContext;
 

test/OpenApiTests/NamingConventions/KebabCase/KebabCaseTests.cs

@@ -4,12 +4,12 @@
 
 namespace OpenApiTests.NamingConventions.KebabCase;
 
-public sealed class PascalCaseTests
+public sealed class KebabCaseTests
     : IClassFixture<OpenApiTestContext<KebabCaseNamingConventionStartup<NamingConventionsDbContext>, NamingConventionsDbContext>>
 {
     private readonly OpenApiTestContext<KebabCaseNamingConventionStartup<NamingConventionsDbContext>, NamingConventionsDbContext> _testContext;
 
-    public PascalCaseTests(OpenApiTestContext<KebabCaseNamingConventionStartup<NamingConventionsDbContext>, NamingConventionsDbContext> testContext)
+    public KebabCaseTests(OpenApiTestContext<KebabCaseNamingConventionStartup<NamingConventionsDbContext>, NamingConventionsDbContext> testContext)
     {
         _testContext = testContext;
 

test/OpenApiTests/OpenApiTestContext.cs

@@ -28,22 +28,22 @@ internal async Task<JsonElement> GetSwaggerDocumentAsync()
 
     private async Task<JsonElement> CreateSwaggerDocumentAsync()
     {
-        string swaggerDocumentOutputPath = GetSwaggerDocumentAbsoluteOutputPath(SwaggerDocumentOutputPath);
+        string absoluteOutputPath = GetSwaggerDocumentAbsoluteOutputPath(SwaggerDocumentOutputPath);
 
         string content = await GetAsync("swagger/v1/swagger.json");
 
-        JsonElement swaggerDocument = ParseSwaggerDocument(content);
-        await WriteToDiskAsync(swaggerDocumentOutputPath, swaggerDocument);
+        JsonElement rootElement = ParseSwaggerDocument(content);
+        await WriteToDiskAsync(absoluteOutputPath, rootElement);
 
-        return swaggerDocument;
+        return rootElement;
     }
 
     private static string GetSwaggerDocumentAbsoluteOutputPath(string? relativePath)
     {
         AssertHasSwaggerDocumentOutputPath(relativePath);
 
         string solutionRoot = Path.Combine(Assembly.GetExecutingAssembly().Location, "../../../../../../");
-        string outputPath = Path.Join(solutionRoot, relativePath, "swagger.g.json");
+        string outputPath = Path.Combine(solutionRoot, relativePath, "swagger.g.json");
 
         return Path.GetFullPath(outputPath);
     }

test/OpenApiTests/OpenApiTests.csproj

@@ -9,6 +9,10 @@
     </None>
   </ItemGroup>
 
+  <ItemGroup>
+    <EmbeddedResource Include="LegacyOpenApiIntegration\swagger.json" />
+  </ItemGroup>
+  
   <ItemGroup>
     <ProjectReference Include="..\..\src\JsonApiDotNetCore.SourceGenerators\JsonApiDotNetCore.SourceGenerators.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
     <ProjectReference Include="..\..\src\JsonApiDotNetCore.OpenApi\JsonApiDotNetCore.OpenApi.csproj" />
@@ -19,10 +23,6 @@
     <PackageReference Include="coverlet.collector" Version="$(CoverletVersion)" PrivateAssets="All" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(AspNetVersion)" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(TestSdkVersion)" />
-    <PackageReference Include="BlushingPenguin.JsonPath" Version="1.0.*" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <EmbeddedResource Include="LegacyOpenApiIntegration\swagger.json" />
+    <PackageReference Include="BlushingPenguin.JsonPath" Version="1.0.3" />
   </ItemGroup>
-</Project>
+</Project>