fix: enumeration exception

maurei · maurei · commit c2484e8cd67b · 2020-08-26T11:52:27.000+02:00
diff --git a/src/JsonApiDotNetCore/Graph/ServiceDiscoveryFacade.cs b/src/JsonApiDotNetCore/Graph/ServiceDiscoveryFacade.cs
@@ -72,7 +72,7 @@ public ServiceDiscoveryFacade AddAssembly(Assembly assembly)
         void IServiceDiscoveryFacade.DiscoverResources()
         {
             
-            foreach (var (assembly, discoveredResourceDescriptors) in  _discoverableAssemblies)
+            foreach (var (assembly, discoveredResourceDescriptors) in  _discoverableAssemblies.ToArray())
             {
                 var resourceDescriptors = GetOrSetResourceDescriptors(discoveredResourceDescriptors, assembly);
 
@@ -86,7 +86,7 @@ void IServiceDiscoveryFacade.DiscoverResources()
         /// <inheritdoc/>
         void IServiceDiscoveryFacade.DiscoverServices()
         {
-            foreach (var (assembly, discoveredResourceDescriptors) in  _discoverableAssemblies)
+            foreach (var (assembly, discoveredResourceDescriptors) in  _discoverableAssemblies.ToArray())
             {
                 AddDbContextResolvers(assembly);
 
diff --git a/test/DiscoveryTests/ServiceDiscoveryFacadeTests.cs b/test/DiscoveryTests/ServiceDiscoveryFacadeTests.cs
@@ -54,7 +54,7 @@ public ServiceDiscoveryFacadeTests()
 
             _resourceGraphBuilder = new ResourceGraphBuilder(options, NullLoggerFactory.Instance);
         }
-        
+
         [Fact]
         public void AddAssembly_Adds_All_Resources_To_Graph()
         {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public ServiceDiscoveryFacade AddAssembly(Assembly assembly)`
`72`	`72`	`void IServiceDiscoveryFacade.DiscoverResources()`
`73`	`73`	`{`
`74`	`74`
`75`		`- foreach (var (assembly, discoveredResourceDescriptors) in _discoverableAssemblies)`
	`75`	`+ foreach (var (assembly, discoveredResourceDescriptors) in _discoverableAssemblies.ToArray())`
`76`	`76`	`{`
`77`	`77`	`var resourceDescriptors = GetOrSetResourceDescriptors(discoveredResourceDescriptors, assembly);`
`78`	`78`
`@@ -86,7 +86,7 @@ void IServiceDiscoveryFacade.DiscoverResources()`
`86`	`86`	`/// <inheritdoc/>`
`87`	`87`	`void IServiceDiscoveryFacade.DiscoverServices()`
`88`	`88`	`{`
`89`		`- foreach (var (assembly, discoveredResourceDescriptors) in _discoverableAssemblies)`
	`89`	`+ foreach (var (assembly, discoveredResourceDescriptors) in _discoverableAssemblies.ToArray())`
`90`	`90`	`{`
`91`	`91`	`AddDbContextResolvers(assembly);`
`92`	`92`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public ServiceDiscoveryFacadeTests()`
`54`	`54`
`55`	`55`	`_resourceGraphBuilder = new ResourceGraphBuilder(options, NullLoggerFactory.Instance);`
`56`	`56`	`}`
`57`		`-`
	`57`	`+`
`58`	`58`	`[Fact]`
`59`	`59`	`public void AddAssembly_Adds_All_Resources_To_Graph()`
`60`	`60`	`{`