Skip to content

Commit bf2df54

Browse files
author
Bart Koelman
authored
Removed case-insensitive comparisons from DisableQueryStringAttribute. (#837)
1 parent eb2dc01 commit bf2df54

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Examples/JsonApiDotNetCoreExample/Services/SkipCacheQueryStringParameterReader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class SkipCacheQueryStringParameterReader : IQueryStringParameterReader
1414

1515
public bool IsEnabled(DisableQueryStringAttribute disableQueryStringAttribute)
1616
{
17-
return !disableQueryStringAttribute.ParameterNames.Contains(_skipCacheParameterName.ToLowerInvariant());
17+
return !disableQueryStringAttribute.ParameterNames.Contains(_skipCacheParameterName);
1818
}
1919

2020
public bool CanRead(string parameterName)

src/JsonApiDotNetCore/Controllers/Annotations/DisableQueryStringAttribute.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public DisableQueryStringAttribute(StandardQueryStringParameters parameters)
3535
if (value != StandardQueryStringParameters.None && value != StandardQueryStringParameters.All &&
3636
parameters.HasFlag(value))
3737
{
38-
parameterNames.Add(value.ToString().ToLowerInvariant());
38+
parameterNames.Add(value.ToString());
3939
}
4040
}
4141

@@ -51,12 +51,12 @@ public DisableQueryStringAttribute(string parameterNames)
5151
{
5252
if (parameterNames == null) throw new ArgumentNullException(nameof(parameterNames));
5353

54-
ParameterNames = parameterNames.Split(",").Select(x => x.Trim().ToLowerInvariant()).ToList();
54+
ParameterNames = parameterNames.Split(",").ToList();
5555
}
5656

5757
public bool ContainsParameter(StandardQueryStringParameters parameter)
5858
{
59-
var name = parameter.ToString().ToLowerInvariant();
59+
var name = parameter.ToString();
6060
return ParameterNames.Contains(name);
6161
}
6262
}

0 commit comments

Comments
 (0)