Skip to content

Commit 9a7ebe0

Browse files
committed
fix: remove unnecessary parameter usejsonapi
1 parent 0b788b5 commit 9a7ebe0

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

src/Examples/JsonApiDotNetCoreExample/Startups/Startup.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ public Startup(IConfiguration configuration) : base(configuration)
2929
public override void ConfigureServices(IServiceCollection services)
3030
{
3131
ConfigureClock(services);
32+
3233
services.AddScoped<SkipCacheQueryStringParameterReader>();
3334
services.AddScoped<IQueryStringParameterReader>(sp => sp.GetService<SkipCacheQueryStringParameterReader>());
3435

src/JsonApiDotNetCore/Builders/IJsonApiApplicationBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ namespace JsonApiDotNetCore.Builders
55
{
66
internal interface IJsonApiApplicationBuilder
77
{
8-
public Action<MvcOptions> ConfigureMvcOptions { get; set; }
8+
public Action<MvcOptions> ConfigureMvcOptions { set; }
99
}
1010
}

src/JsonApiDotNetCore/Extensions/ApplicationBuilderExtensions.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public static class ApplicationBuilderExtensions
1515
/// Registers the JsonApiDotNetCore middleware.
1616
/// </summary>
1717
/// <param name="builder">The <see cref="IApplicationBuilder"/> to add the middleware to.</param>
18-
/// <param name="configureMvcOptions">Configure .NET Core MVC options</param>
1918
/// <example>
2019
/// The code below is the minimal that is required for proper activation,
2120
/// which should be added to your Startup.Configure method.
@@ -25,16 +24,14 @@ public static class ApplicationBuilderExtensions
2524
/// app.UseEndpoints(endpoints => endpoints.MapControllers());
2625
/// ]]></code>
2726
/// </example>
28-
public static void UseJsonApi(this IApplicationBuilder builder, Action<MvcOptions> configureMvcOptions = null)
27+
public static void UseJsonApi(this IApplicationBuilder builder)
2928
{
3029
var jsonApiApplicationBuilder = builder.ApplicationServices.GetRequiredService<IJsonApiApplicationBuilder>();
3130
jsonApiApplicationBuilder.ConfigureMvcOptions = options =>
3231
{
3332
options.InputFormatters.Insert(0, builder.ApplicationServices.GetRequiredService<IJsonApiInputFormatter>());
3433
options.OutputFormatters.Insert(0, builder.ApplicationServices.GetRequiredService<IJsonApiOutputFormatter>());
3534
options.Conventions.Insert(0, builder.ApplicationServices.GetRequiredService<IJsonApiRoutingConvention>());
36-
37-
configureMvcOptions?.Invoke(options);
3835
};
3936

4037
builder.UseMiddleware<JsonApiMiddleware>();

0 commit comments

Comments
 (0)