fix: fixced isimmutable not working

Harro van der  Kroft · Harro van der  Kroft · commit 943a7e3c823d · 2019-05-16T14:57:28.000+02:00
diff --git a/src/JsonApiDotNetCore/Models/AttrAttribute.cs b/src/JsonApiDotNetCore/Models/AttrAttribute.cs
@@ -32,6 +32,7 @@ public AttrAttribute(string publicName = null, bool isImmutable = false, bool is
             IsImmutable = isImmutable;
             IsFilterable = isFilterable;
             IsSortable = isSortable;
+
         }
 
         /// <summary>
diff --git a/src/JsonApiDotNetCore/Serialization/JsonApiDeSerializer.cs b/src/JsonApiDotNetCore/Serialization/JsonApiDeSerializer.cs
@@ -146,11 +146,11 @@ private object SetEntityAttributes(
             {
                 if (attributeValues.TryGetValue(attr.PublicAttributeName, out object newValue))
                 {
+                    if (attr.IsImmutable)
+                        continue;
                     var convertedValue = ConvertAttrValue(newValue, attr.PropertyInfo.PropertyType);
                     attr.SetValue(entity, convertedValue);
-
-                    if (attr.IsImmutable == false)
-                        _jsonApiContext.AttributesToUpdate[attr] = convertedValue;
+                    _jsonApiContext.AttributesToUpdate[attr] = convertedValue;
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ public AttrAttribute(string publicName = null, bool isImmutable = false, bool is`
`32`	`32`	`IsImmutable = isImmutable;`
`33`	`33`	`IsFilterable = isFilterable;`
`34`	`34`	`IsSortable = isSortable;`
	`35`	`+`
`35`	`36`	`}`
`36`	`37`
`37`	`38`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -146,11 +146,11 @@ private object SetEntityAttributes(`
`146`	`146`	`{`
`147`	`147`	`if (attributeValues.TryGetValue(attr.PublicAttributeName, out object newValue))`
`148`	`148`	`{`
	`149`	`+ if (attr.IsImmutable)`
	`150`	`+ continue;`
`149`	`151`	`var convertedValue = ConvertAttrValue(newValue, attr.PropertyInfo.PropertyType);`
`150`	`152`	`attr.SetValue(entity, convertedValue);`
`151`		`-`
`152`		`- if (attr.IsImmutable == false)`
`153`		`- _jsonApiContext.AttributesToUpdate[attr] = convertedValue;`
	`153`	`+ _jsonApiContext.AttributesToUpdate[attr] = convertedValue;`
`154`	`154`	`}`
`155`	`155`	`}`
`156`	`156`