Skip to content

Commit 890d91a

Browse files
committed
chore: self review
1 parent 693c138 commit 890d91a

File tree

3 files changed

+2
-39
lines changed

3 files changed

+2
-39
lines changed

src/JsonApiDotNetCore/Middleware/IncomingTypeMatchFilter.cs

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -49,19 +49,7 @@ public void OnActionExecuting(ActionExecutingContext context)
4949
}
5050
}
5151
}
52-
53-
private void ThrowIfResourceTypeMismatch(Type deserializedType, Type targetType, HttpRequest request)
54-
{
55-
if (deserializedType != targetType)
56-
{
57-
ResourceContext resourceFromEndpoint = _provider.GetResourceContext(targetType);
58-
ResourceContext resourceFromBody = _provider.GetResourceContext(deserializedType);
59-
60-
throw new ResourceTypeMismatchException(new HttpMethod(request.Method), request.Path, resourceFromEndpoint,
61-
resourceFromBody);
62-
}
63-
}
64-
52+
6553
public void OnActionExecuted(ActionExecutedContext context) { /* noop */ }
6654
}
6755
}

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/CreatingDataTests.cs

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -274,31 +274,6 @@ public async Task CreateResource_SimpleResource_HeaderLocationsAreCorrect()
274274
Assert.Equal($"/api/v1/todoItems/{responseItem.Id}", response.Headers.Location.ToString());
275275
}
276276

277-
[Fact]
278-
public async Task CreateResource_ResourceTypeMismatch_IsConflict()
279-
{
280-
// Arrange
281-
string content = JsonConvert.SerializeObject(new
282-
{
283-
data = new
284-
{
285-
type = "people"
286-
}
287-
});
288-
289-
// Act
290-
var (body, response) = await Post("/api/v1/todoItems", content);
291-
292-
// Assert
293-
AssertEqualStatusCode(HttpStatusCode.Conflict, response);
294-
295-
var errorDocument = JsonConvert.DeserializeObject<ErrorDocument>(body);
296-
Assert.Single(errorDocument.Errors);
297-
Assert.Equal(HttpStatusCode.Conflict, errorDocument.Errors[0].StatusCode);
298-
Assert.Equal("Resource type mismatch between request body and endpoint URL.", errorDocument.Errors[0].Title);
299-
Assert.Equal("Expected resource of type 'todoItems' in POST request body at endpoint '/api/v1/todoItems', instead of 'people'.", errorDocument.Errors[0].Detail);
300-
}
301-
302277
[Fact]
303278
public async Task CreateResource_UnknownResourceType_Fails()
304279
{

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/UpdatingRelationshipsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ public async Task Can_Update_ToMany_Relationship_By_Patching_Resource()
282282
// a "complete replace".
283283
Assert.Equal(2, updatedTodoItems.Count);
284284
}
285-
285+
286286
[Fact]
287287
public async Task Can_Update_ToMany_Relationship_By_Patching_Resource_When_Targets_Already_Attached()
288288
{

0 commit comments

Comments
 (0)