Skip to content

Commit 83139cc

Browse files
committed
cleanup tests
1 parent 84e9e04 commit 83139cc

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

test/JsonApiDotNetCoreExampleTests/Acceptance/ManyToManyTests.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1+
using System;
12
using System.Collections.Generic;
23
using System.Linq;
34
using System.Net;
45
using System.Net.Http;
56
using System.Net.Http.Headers;
67
using System.Threading.Tasks;
78
using Bogus;
9+
using JsonApiDotNetCore.Models;
810
using JsonApiDotNetCore.Serialization;
911
using JsonApiDotNetCoreExample.Data;
1012
using JsonApiDotNetCoreExample.Models;
@@ -50,27 +52,26 @@ public async Task Can_Fetch_Many_To_Many_Through_All()
5052

5153
var route = $"/api/v1/articles?include=tags";
5254

53-
54-
5555
// act
5656
var response = await _fixture.Client.GetAsync(route);
5757

5858
// assert
5959
var body = await response.Content.ReadAsStringAsync();
6060
Assert.True(HttpStatusCode.OK == response.StatusCode, $"{route} returned {response.StatusCode} status code with payload: {body}");
6161

62-
Assert.True(body.Contains("include"));
62+
var document = JsonConvert.DeserializeObject<Documents>(body);
63+
Assert.NotEmpty(document.Included);
6364

6465
var articleResponseList = _fixture.GetService<IJsonApiDeSerializer>().DeserializeList<Article>(body);
6566
Assert.NotNull(articleResponseList);
67+
6668
var articleResponse = articleResponseList.FirstOrDefault(a => a.Id == article.Id);
6769
Assert.NotNull(articleResponse);
6870
Assert.Equal(article.Name, articleResponse.Name);
6971

7072
var tagResponse = Assert.Single(articleResponse.Tags);
7173
Assert.Equal(tag.Id, tagResponse.Id);
7274
Assert.Equal(tag.Name, tagResponse.Name);
73-
7475
}
7576

7677
[Fact]
@@ -96,7 +97,9 @@ public async Task Can_Fetch_Many_To_Many_Through_GetById()
9697
// assert
9798
var body = await response.Content.ReadAsStringAsync();
9899
Assert.True(HttpStatusCode.OK == response.StatusCode, $"{route} returned {response.StatusCode} status code with payload: {body}");
99-
Assert.True(body.Contains("include"));
100+
101+
var document = JsonConvert.DeserializeObject<Document>(body);
102+
Assert.NotEmpty(document.Included);
100103

101104
var articleResponse = _fixture.GetService<IJsonApiDeSerializer>().Deserialize<Article>(body);
102105
Assert.NotNull(articleResponse);
@@ -105,7 +108,6 @@ public async Task Can_Fetch_Many_To_Many_Through_GetById()
105108
var tagResponse = Assert.Single(articleResponse.Tags);
106109
Assert.Equal(tag.Id, tagResponse.Id);
107110
Assert.Equal(tag.Name, tagResponse.Name);
108-
109111
}
110112

111113
[Fact]

0 commit comments

Comments
 (0)