Apply global convention for all integration tests: change DeleteBehavior.ClientSetNull to DeleteBehavior.SetNull

This improves speed and reduces the number of errors logged by the PostgreSQL server when running tests, because we no longer need the "truncate table cascade" fallback in DbContextExtensions.

Author: bkoelman

test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/OperationsDbContext.cs

@@ -31,5 +31,7 @@ protected override void OnModelCreating(ModelBuilder builder)
         builder.Entity<MusicTrack>()
             .HasMany(musicTrack => musicTrack.OccursIn)
             .WithMany(playlist => playlist.Tracks);
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys/CompositeDbContext.cs

@@ -39,5 +39,7 @@ protected override void OnModelCreating(ModelBuilder builder)
         builder.Entity<Car>()
             .HasMany(car => car.PreviousDealerships)
             .WithMany(dealership => dealership.SoldCars);
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/EagerLoadingDbContext.cs

@@ -34,5 +34,7 @@ protected override void OnModelCreating(ModelBuilder builder)
             .HasOne(building => building.SecondaryDoor)
             .WithOne()
             .HasForeignKey<Building>("SecondaryDoorId");
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/InputValidation/ModelState/ModelStateDbContext.cs

@@ -37,5 +37,7 @@ protected override void OnModelCreating(ModelBuilder builder)
         builder.Entity<SystemDirectory>()
             .HasOne(systemDirectory => systemDirectory.AlsoSelf)
             .WithOne();
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/Links/LinksDbContext.cs

@@ -24,5 +24,7 @@ protected override void OnModelCreating(ModelBuilder builder)
             .HasOne(photo => photo.Location)
             .WithOne(location => location.Photo)
             .HasForeignKey<Photo>("LocationId");
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/MultiTenancy/MultiTenancyDbContext.cs

@@ -31,5 +31,7 @@ protected override void OnModelCreating(ModelBuilder builder)
 
         builder.Entity<WebProduct>()
             .HasQueryFilter(webProduct => webProduct.Shop.TenantId == _tenantProvider.TenantId);
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/Filtering/FilterDbContext.cs

@@ -21,5 +21,7 @@ protected override void OnModelCreating(ModelBuilder builder)
         builder.Entity<FilterableResource>()
             .Property(resource => resource.SomeDateTimeInLocalZone)
             .HasColumnType("timestamp without time zone");
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/QueryStringDbContext.cs

@@ -37,5 +37,7 @@ protected override void OnModelCreating(ModelBuilder builder)
             .HasOne(man => man.Wife)
             .WithOne(woman => woman.Husband)
             .HasForeignKey<Man>();
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/ReadWriteDbContext.cs

@@ -49,5 +49,7 @@ protected override void OnModelCreating(ModelBuilder builder)
                 left => left
                     .HasOne(joinEntity => joinEntity.ToItem)
                     .WithMany());
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/RequiredRelationships/DefaultBehaviorDbContext.cs

@@ -33,5 +33,7 @@ protected override void OnModelCreating(ModelBuilder builder)
             .HasOne(order => order.Shipment)
             .WithOne(shipment => shipment.Order)
             .HasForeignKey<Shipment>("OrderId");
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/ResourceDefinitions/Serialization/SerializationDbContext.cs

@@ -22,5 +22,7 @@ protected override void OnModelCreating(ModelBuilder builder)
         builder.Entity<Scholarship>()
             .HasMany(scholarship => scholarship.Participants)
             .WithOne(student => student.Scholarship!);
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/ResourceInheritance/ResourceInheritanceReadTests.cs

@@ -2429,7 +2429,7 @@ public async Task Can_sort_on_derived_attribute_from_resource_definition_using_e
 
         await _testContext.RunOnDatabaseAsync(async dbContext =>
         {
-            await dbContext.ClearTableAsync<Vehicle>();
+            await dbContext.ClearTableAsync<Wheel>();
             dbContext.Wheels.AddRange(chromeWheel1, chromeWheel2, chromeWheel3, carbonWheel1, carbonWheel2);
             await dbContext.SaveChangesAsync();
         });
@@ -2487,7 +2487,7 @@ public async Task Can_sort_on_derived_attribute_from_resource_definition_using_l
 
         await _testContext.RunOnDatabaseAsync(async dbContext =>
         {
-            await dbContext.ClearTableAsync<Vehicle>();
+            await dbContext.ClearTableAsync<Wheel>();
             dbContext.Wheels.AddRange(chromeWheel1, chromeWheel2, chromeWheel3, carbonWheel1, carbonWheel2);
             await dbContext.SaveChangesAsync();
         });

test/JsonApiDotNetCoreTests/IntegrationTests/ResourceInheritance/TablePerType/TablePerTypeDbContext.cs

@@ -32,5 +32,7 @@ protected override void OnModelCreating(ModelBuilder builder)
         builder.Entity<GenericProperty>().ToTable("GenericProperties");
         builder.Entity<StringProperty>().ToTable("StringProperties");
         builder.Entity<NumberProperty>().ToTable("NumberProperties");
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/SoftDeletion/SoftDeletionDbContext.cs

@@ -24,5 +24,7 @@ protected override void OnModelCreating(ModelBuilder builder)
 
         builder.Entity<Department>()
             .HasQueryFilter(department => department.SoftDeletedAt == null);
+
+        base.OnModelCreating(builder);
     }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/ZeroKeys/ZeroKeyDbContext.cs

@@ -27,5 +27,7 @@ protected override void OnModelCreating(ModelBuilder builder)
         builder.Entity<Player>()
             .HasOne(player => player.ActiveGame)
             .WithMany(game => game.ActivePlayers);
+
+        base.OnModelCreating(builder);
     }
 }

test/TestBuildingBlocks/DbContextExtensions.cs

@@ -1,6 +1,5 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Metadata;
-using Npgsql;
 
 namespace TestBuildingBlocks;
 
@@ -36,17 +35,7 @@ private static async Task ClearTablesAsync(this DbContext dbContext, params Type
             }
 
             string tableName = entityType.GetTableName()!;
-
-            // PERF: We first try to clear the table, which is fast and usually succeeds, unless foreign key constraints are violated.
-            // In that case, we recursively delete all related data, which is slow.
-            try
-            {
-                await dbContext.Database.ExecuteSqlRawAsync($"delete from \"{tableName}\"");
-            }
-            catch (PostgresException)
-            {
-                await dbContext.Database.ExecuteSqlRawAsync($"truncate table \"{tableName}\" cascade");
-            }
+            await dbContext.Database.ExecuteSqlRawAsync($"delete from \"{tableName}\"");
         }
     }
 }

test/TestBuildingBlocks/TestableDbContext.cs

@@ -1,6 +1,7 @@
 using System.Diagnostics;
 using JsonApiDotNetCore;
 using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Metadata;
 using Microsoft.Extensions.Logging;
 
 namespace TestBuildingBlocks;
@@ -17,4 +18,15 @@ protected override void OnConfiguring(DbContextOptionsBuilder builder)
         // Writes SQL statements to the Output Window when debugging.
         builder.LogTo(message => Debug.WriteLine(message), DbLoggerCategory.Database.Name.AsArray(), LogLevel.Information);
     }
+
+    protected override void OnModelCreating(ModelBuilder builder)
+    {
+        foreach (IMutableForeignKey foreignKey in builder.Model.GetEntityTypes().SelectMany(entityType => entityType.GetForeignKeys()))
+        {
+            if (foreignKey.DeleteBehavior == DeleteBehavior.ClientSetNull)
+            {
+                foreignKey.DeleteBehavior = DeleteBehavior.SetNull;
+            }
+        }
+    }
 }