fix(Attr/RelationshipAttibute): make setters internal

Author: jaredcnance

benchmarks/Query/QueryParser_Benchmarks.cs

@@ -24,9 +24,7 @@ public QueryParser_Benchmarks() {
             var controllerContextMock = new Mock<IControllerContext>();
             controllerContextMock.Setup(m => m.RequestEntity).Returns(new ContextEntity {
                 Attributes = new List<AttrAttribute> {
-                    new AttrAttribute(ATTRIBUTE) {
-                        InternalAttributeName = ATTRIBUTE
-                    }
+                    new AttrAttribute(ATTRIBUTE, ATTRIBUTE)
                 }
             });
             var options = new JsonApiOptions();

src/JsonApiDotNetCore/AssemblyInfo.cs

@@ -2,3 +2,4 @@
 [assembly:InternalsVisibleTo("UnitTests")]
 [assembly:InternalsVisibleTo("JsonApiDotNetCoreExampleTests")]
 [assembly:InternalsVisibleTo("NoEntityFrameworkTests")]
+[assembly:InternalsVisibleTo("Benchmarks")]

src/JsonApiDotNetCore/Models/AttrAttribute.cs

@@ -21,7 +21,7 @@ internal AttrAttribute(string publicName, string internalName, bool isImmutable
         }
 
         public string PublicAttributeName { get; }
-        public string InternalAttributeName { get; }
+        public string InternalAttributeName { get; internal set; }
         public bool IsImmutable { get; }
         public bool IsFilterable { get; }
         public bool IsSortable { get; }

src/JsonApiDotNetCore/Models/HasManyAttribute.cs

@@ -1,14 +1,10 @@
-using System.Reflection;
-
 namespace JsonApiDotNetCore.Models
 {
     public class HasManyAttribute : RelationshipAttribute
     {
         public HasManyAttribute(string publicName, Link documentLinks = Link.All)
         : base(publicName, documentLinks)
-        {
-            PublicRelationshipName = publicName;
-        }
+        { }
 
         public override void SetValue(object entity, object newValue)
         {

src/JsonApiDotNetCore/Models/HasOneAttribute.cs

@@ -1,14 +1,10 @@
-using System.Reflection;
-
 namespace JsonApiDotNetCore.Models
 {
     public class HasOneAttribute : RelationshipAttribute
     {
         public HasOneAttribute(string publicName, Link documentLinks = Link.All)
         : base(publicName, documentLinks)
-        {
-            PublicRelationshipName = publicName;
-        }
+        { }
 
         public override void SetValue(object entity, object newValue)
         {

src/JsonApiDotNetCore/Models/RelationshipAttribute.cs

@@ -11,8 +11,8 @@ protected RelationshipAttribute(string publicName, Link documentLinks)
         }
 
         public string PublicRelationshipName { get; }
-        public string InternalRelationshipName { get; }
-        public Type Type { get; }
+        public string InternalRelationshipName { get; internal set; }
+        public Type Type { get; internal set; }
         public bool IsHasMany => GetType() == typeof(HasManyAttribute);
         public bool IsHasOne => GetType() == typeof(HasOneAttribute);
         public Link DocumentLinks { get; } = Link.All;