Fix false-positive warning on possible multiple enumeration

Author: ThomasBarnekow

src/JsonApiDotNetCore/Queries/NoSqlQueryLayerComposer.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using JetBrains.Annotations;
 using JsonApiDotNetCore.Configuration;
@@ -8,6 +9,7 @@
 using JsonApiDotNetCore.Resources;
 using JsonApiDotNetCore.Resources.Annotations;
 
+#pragma warning disable AV1551 // Method overload should call another overload
 #pragma warning disable AV2310 // Code block should not contain inline comment
 
 namespace JsonApiDotNetCore.Queries
@@ -36,6 +38,8 @@ public class NoSqlQueryLayerComposer : QueryLayerComposer, INoSqlQueryLayerCompo
         private readonly IEnumerable<IQueryConstraintProvider> _constraintProviders;
         private readonly ITargetedFields _targetedFields;
 
+        // ReSharper disable PossibleMultipleEnumeration
+
         public NoSqlQueryLayerComposer(
             IEnumerable<IQueryConstraintProvider> constraintProviders,
             IResourceDefinitionAccessor resourceDefinitionAccessor,
@@ -50,6 +54,8 @@ public NoSqlQueryLayerComposer(
             _targetedFields = targetedFields;
         }
 
+        // ReSharper restore PossibleMultipleEnumeration
+
         /// <inheritdoc />
         public FilterExpression? GetPrimaryFilterFromConstraintsForNoSql(ResourceType primaryResourceType)
         {

src/JsonApiDotNetCore/Services/NoSqlResourceService.cs

@@ -20,6 +20,7 @@
 using Microsoft.Extensions.Logging;
 using SysNotNull = System.Diagnostics.CodeAnalysis.NotNullAttribute;
 
+#pragma warning disable AV1551 // Method overload should call another overload
 #pragma warning disable AV2310 // Code block should not contain inline comment
 #pragma warning disable AV2318 // Work-tracking TO DO comment should be removed
 #pragma warning disable AV2407 // Region should be removed
@@ -642,16 +643,13 @@ private static void AssertRelationshipInJsonApiRequestIsNotNull([SysNotNull] Rel
             Type type = resource.GetType();
             PropertyInfo? property = type.GetProperty(propertyName);
 
-            if (property is null)
-            {
-                throw new JsonApiException(new ErrorObject(HttpStatusCode.InternalServerError)
+            return property is not null
+                ? property.GetValue(resource)?.ToString()
+                : throw new JsonApiException(new ErrorObject(HttpStatusCode.InternalServerError)
                 {
                     Title = "Invalid property.",
                     Detail = $"The '{type.Name}' type does not have a '{propertyName}' property."
                 });
-            }
-
-            return property.GetValue(resource)?.ToString();
         }
 
         #endregion Implementation