Fixed: allow the use of quality factor in Accept header (content negotiation)

Author: Bart Koelman

src/JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs

@@ -23,6 +23,8 @@ namespace JsonApiDotNetCore.Middleware
     /// </summary>
     public sealed class JsonApiMiddleware
     {
+        private static readonly MediaTypeHeaderValue _mediaType = MediaTypeHeaderValue.Parse(HeaderConstants.MediaType);
+
         private readonly RequestDelegate _next;
 
         public JsonApiMiddleware(RequestDelegate next)
@@ -96,7 +98,7 @@ private static async Task<bool> ValidateContentTypeHeaderAsync(HttpContext httpC
         private static async Task<bool> ValidateAcceptHeaderAsync(HttpContext httpContext, JsonSerializerSettings serializerSettings)
         {
             StringValues acceptHeaders = httpContext.Request.Headers["Accept"];
-            if (!acceptHeaders.Any() || acceptHeaders == HeaderConstants.MediaType)
+            if (!acceptHeaders.Any())
             {
                 return true;
             }
@@ -105,15 +107,17 @@ private static async Task<bool> ValidateAcceptHeaderAsync(HttpContext httpContex
 
             foreach (var acceptHeader in acceptHeaders)
             {
-                if (MediaTypeHeaderValue.TryParse(acceptHeader, out var headerValue))
+                if (MediaTypeWithQualityHeaderValue.TryParse(acceptHeader, out var headerValue))
                 {
+                    headerValue.Quality = null;
+
                     if (headerValue.MediaType == "*/*" || headerValue.MediaType == "application/*")
                     {
                         seenCompatibleMediaType = true;
                         break;
                     }
 
-                    if (headerValue.MediaType == HeaderConstants.MediaType && !headerValue.Parameters.Any())
+                    if (_mediaType.Equals(headerValue))
                     {
                         seenCompatibleMediaType = true;
                         break;
@@ -126,7 +130,7 @@ private static async Task<bool> ValidateAcceptHeaderAsync(HttpContext httpContex
                 await FlushResponseAsync(httpContext.Response, serializerSettings, new Error(HttpStatusCode.NotAcceptable)
                 {
                     Title = "The specified Accept header value does not contain any supported media types.",
-                    Detail = $"Please include '{HeaderConstants.MediaType}' in the Accept header values."
+                    Detail = $"Please include '{_mediaType}' in the Accept header values."
                 });
                 return false;
             }

test/JsonApiDotNetCoreExampleTests/IntegrationTests/ContentNegotiation/AcceptHeaderTests.cs

@@ -4,9 +4,6 @@
 using FluentAssertions;
 using JsonApiDotNetCore.Middleware;
 using JsonApiDotNetCore.Serialization.Objects;
-using JsonApiDotNetCoreExample;
-using JsonApiDotNetCoreExample.Data;
-using JsonApiDotNetCoreExample.Models;
 using Xunit;
 
 namespace JsonApiDotNetCoreExampleTests.IntegrationTests.ContentNegotiation
@@ -86,7 +83,7 @@ public async Task Permits_JsonApi_without_parameters_in_Accept_headers()
                 MediaTypeWithQualityHeaderValue.Parse(HeaderConstants.MediaType + "; profile=some"),
                 MediaTypeWithQualityHeaderValue.Parse(HeaderConstants.MediaType + "; ext=other"),
                 MediaTypeWithQualityHeaderValue.Parse(HeaderConstants.MediaType + "; unknown=unexpected"),
-                MediaTypeWithQualityHeaderValue.Parse(HeaderConstants.MediaType)
+                MediaTypeWithQualityHeaderValue.Parse(HeaderConstants.MediaType + "; q=0.3")
             };
 
             // Act

test/JsonApiDotNetCoreExampleTests/IntegrationTests/ContentNegotiation/ContentTypeHeaderTests.cs

@@ -3,7 +3,6 @@
 using FluentAssertions;
 using JsonApiDotNetCore.Middleware;
 using JsonApiDotNetCore.Serialization.Objects;
-using JsonApiDotNetCoreExample.Models;
 using Xunit;
 
 namespace JsonApiDotNetCoreExampleTests.IntegrationTests.ContentNegotiation