Add missing test to client generation modes

Author: bkoelman

test/OpenApiKiotaEndToEndTests/ClientIdGenerationModes/ClientIdGenerationModesTests.cs

@@ -183,6 +183,49 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         });
     }
 
+    [Fact]
+    public async Task Cannot_create_resource_with_existing_ID_when_supplying_ID_is_allowed()
+    {
+        // Arrange
+        Game existingGame = _fakers.Game.Generate();
+
+        await _testContext.RunOnDatabaseAsync(async dbContext =>
+        {
+            dbContext.Games.Add(existingGame);
+            await dbContext.SaveChangesAsync();
+        });
+
+        using HttpClientRequestAdapter requestAdapter = _requestAdapterFactory.CreateAdapter(_testContext.Factory);
+        ClientIdGenerationModesClient apiClient = new(requestAdapter);
+
+        var requestBody = new GamePostRequestDocument
+        {
+            Data = new GameDataInPostRequest
+            {
+                Type = GameResourceType.Games,
+                Id = existingGame.StringId,
+                Attributes = new GameAttributesInPostRequest
+                {
+                    Title = existingGame.Title,
+                    PurchasePrice = (double)existingGame.PurchasePrice
+                }
+            }
+        };
+
+        // Act
+        Func<Task> action = async () => _ = await apiClient.Games.PostAsync(requestBody);
+
+        // Assert
+        ErrorResponseDocument exception = (await action.Should().ThrowExactlyAsync<ErrorResponseDocument>()).Which;
+        exception.ResponseStatusCode.Should().Be((int)HttpStatusCode.Conflict);
+        exception.Errors.ShouldHaveCount(1);
+
+        ErrorObject error = exception.Errors.ElementAt(0);
+        error.Status.Should().Be("409");
+        error.Title.Should().Be("Another resource with the specified ID already exists.");
+        error.Detail.Should().Be($"Another resource of type 'games' with ID '{existingGame.StringId}' already exists.");
+    }
+
     [Fact]
     public async Task Can_create_resource_without_ID_when_supplying_ID_is_forbidden()
     {

test/OpenApiNSwagEndToEndTests/ClientIdGenerationModes/ClientIdGenerationModesTests.cs

@@ -1,3 +1,4 @@
+using System.Net;
 using FluentAssertions;
 using FluentAssertions.Specialized;
 using JsonApiDotNetCore.OpenApi.Client.NSwag;
@@ -7,18 +8,22 @@
 using OpenApiTests.ClientIdGenerationModes;
 using TestBuildingBlocks;
 using Xunit;
+using Xunit.Abstractions;
 
 namespace OpenApiNSwagEndToEndTests.ClientIdGenerationModes;
 
 public sealed class ClientIdGenerationModesTests
     : IClassFixture<IntegrationTestContext<OpenApiStartup<ClientIdGenerationDbContext>, ClientIdGenerationDbContext>>
 {
     private readonly IntegrationTestContext<OpenApiStartup<ClientIdGenerationDbContext>, ClientIdGenerationDbContext> _testContext;
+    private readonly XUnitLogHttpMessageHandler _logHttpMessageHandler;
     private readonly ClientIdGenerationFakers _fakers = new();
 
-    public ClientIdGenerationModesTests(IntegrationTestContext<OpenApiStartup<ClientIdGenerationDbContext>, ClientIdGenerationDbContext> testContext)
+    public ClientIdGenerationModesTests(IntegrationTestContext<OpenApiStartup<ClientIdGenerationDbContext>, ClientIdGenerationDbContext> testContext,
+        ITestOutputHelper testOutputHelper)
     {
         _testContext = testContext;
+        _logHttpMessageHandler = new XUnitLogHttpMessageHandler(testOutputHelper);
 
         testContext.UseController<PlayersController>();
         testContext.UseController<GamesController>();
@@ -31,7 +36,7 @@ public async Task Cannot_create_resource_without_ID_when_supplying_ID_is_require
         // Arrange
         Player newPlayer = _fakers.Player.Generate();
 
-        using HttpClient httpClient = _testContext.Factory.CreateClient();
+        using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
         ClientIdGenerationModesClient apiClient = new(httpClient);
 
         var requestBody = new PlayerPostRequestDocument
@@ -60,7 +65,7 @@ public async Task Can_create_resource_with_ID_when_supplying_ID_is_required()
         Player newPlayer = _fakers.Player.Generate();
         newPlayer.Id = Guid.NewGuid();
 
-        using HttpClient httpClient = _testContext.Factory.CreateClient();
+        using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
         ClientIdGenerationModesClient apiClient = new(httpClient);
 
         var requestBody = new PlayerPostRequestDocument
@@ -95,7 +100,7 @@ public async Task Can_create_resource_without_ID_when_supplying_ID_is_allowed()
         // Arrange
         Game newGame = _fakers.Game.Generate();
 
-        using HttpClient httpClient = _testContext.Factory.CreateClient();
+        using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
         ClientIdGenerationModesClient apiClient = new(httpClient);
 
         var requestBody = new GamePostRequestDocument
@@ -135,7 +140,7 @@ public async Task Can_create_resource_with_ID_when_supplying_ID_is_allowed()
         Game newGame = _fakers.Game.Generate();
         newGame.Id = Guid.NewGuid();
 
-        using HttpClient httpClient = _testContext.Factory.CreateClient();
+        using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
         ClientIdGenerationModesClient apiClient = new(httpClient);
 
         var requestBody = new GamePostRequestDocument
@@ -166,13 +171,56 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         });
     }
 
+    [Fact]
+    public async Task Cannot_create_resource_with_existing_ID_when_supplying_ID_is_allowed()
+    {
+        // Arrange
+        Game existingGame = _fakers.Game.Generate();
+
+        await _testContext.RunOnDatabaseAsync(async dbContext =>
+        {
+            dbContext.Games.Add(existingGame);
+            await dbContext.SaveChangesAsync();
+        });
+
+        using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
+        ClientIdGenerationModesClient apiClient = new(httpClient);
+
+        var requestBody = new GamePostRequestDocument
+        {
+            Data = new GameDataInPostRequest
+            {
+                Id = existingGame.StringId!,
+                Attributes = new GameAttributesInPostRequest
+                {
+                    Title = existingGame.Title,
+                    PurchasePrice = (double)existingGame.PurchasePrice
+                }
+            }
+        };
+
+        // Act
+        Func<Task> action = async () => _ = await apiClient.PostGameAsync(null, requestBody);
+
+        // Assert
+        ApiException<ErrorResponseDocument> exception = (await action.Should().ThrowExactlyAsync<ApiException<ErrorResponseDocument>>()).Which;
+        exception.StatusCode.Should().Be((int)HttpStatusCode.Conflict);
+        exception.Message.Should().Be("HTTP 409: The request body contains conflicting information or another resource with the same ID already exists.");
+        exception.Result.Errors.ShouldHaveCount(1);
+
+        ErrorObject error = exception.Result.Errors.ElementAt(0);
+        error.Status.Should().Be("409");
+        error.Title.Should().Be("Another resource with the specified ID already exists.");
+        error.Detail.Should().Be($"Another resource of type 'games' with ID '{existingGame.StringId}' already exists.");
+    }
+
     [Fact]
     public async Task Can_create_resource_without_ID_when_supplying_ID_is_forbidden()
     {
         // Arrange
         PlayerGroup newPlayerGroup = _fakers.Group.Generate();
 
-        using HttpClient httpClient = _testContext.Factory.CreateClient();
+        using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
         ClientIdGenerationModesClient apiClient = new(httpClient);
 
         var requestBody = new PlayerGroupPostRequestDocument