Tracked at #758

Bart Koelman · Bart Koelman · commit 64062825e3a7 · 2020-05-14T18:39:49.000+02:00
diff --git a/src/JsonApiDotNetCore/QueryParameterServices/FilterService.cs b/src/JsonApiDotNetCore/QueryParameterServices/FilterService.cs
@@ -74,7 +74,6 @@ private FilterQueryContext GetQueryContexts(FilterQuery query, string parameterN
             return queryContext;
         }
 
-        /// todo: this could be simplified a bunch 
         private List<FilterQuery> GetFilterQueries(string parameterName, StringValues parameterValue)
         {
             // expected input = filter[id]=1
@@ -100,7 +99,6 @@ private List<FilterQuery> GetFilterQueries(string parameterName, StringValues pa
             return queries;
         }
 
-        /// todo: this could be simplified a bunch 
         private (string operation, string value) ParseFilterOperation(string value)
         {
             if (value.Length < 3)
@@ -117,7 +115,6 @@ private List<FilterQuery> GetFilterQueries(string parameterName, StringValues pa
             return (operation, value);
         }
 
-        /// todo: this could be simplified a bunch 
         private string GetFilterOperation(string value)
         {
             var values = value.Split(QueryConstants.COLON);

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,6 @@ private FilterQueryContext GetQueryContexts(FilterQuery query, string parameterN`
`74`	`74`	`return queryContext;`
`75`	`75`	`}`
`76`	`76`
`77`		`- /// todo: this could be simplified a bunch`
`78`	`77`	`private List<FilterQuery> GetFilterQueries(string parameterName, StringValues parameterValue)`
`79`	`78`	`{`
`80`	`79`	`// expected input = filter[id]=1`
`@@ -100,7 +99,6 @@ private List<FilterQuery> GetFilterQueries(string parameterName, StringValues pa`
`100`	`99`	`return queries;`
`101`	`100`	`}`
`102`	`101`
`103`		`- /// todo: this could be simplified a bunch`
`104`	`102`	`private (string operation, string value) ParseFilterOperation(string value)`
`105`	`103`	`{`
`106`	`104`	`if (value.Length < 3)`
`@@ -117,7 +115,6 @@ private List<FilterQuery> GetFilterQueries(string parameterName, StringValues pa`
`117`	`115`	`return (operation, value);`
`118`	`116`	`}`
`119`	`117`
`120`		`- /// todo: this could be simplified a bunch`
`121`	`118`	`private string GetFilterOperation(string value)`
`122`	`119`	`{`
`123`	`120`	`var values = value.Split(QueryConstants.COLON);`